-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add healthProbeBindAddr
flag in helm chart
#4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: niclask25 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @niclask25. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
… due to conflict in OS/ES Signed-off-by: Daniel Brown <[email protected]>
remove auto-generated file address comments support enable manage backend SG rules for NLB
Updates the Backend Security Groups configuration documentation to clarify important requirements for using Custom Shared Backend Security Groups.
We received feedback about this page, expressing the need to clarify the controller configuration options content and to direct users to the actual supported Helm chart options.
…tes-sigs#4150) * [gw api] tg creation * fixes to get tg + tgb working * make logging less noisy * refactor duplicated consts * tg tests * fix interval and timeout to appease alb * use shared constant for health check port * refactor multicluster to target group props * refactor to use route kind enum * infer target group type from route
|
This reverts commit a8d856a.
@niclask25 Thank you for your contribution! We appreciate you taking the time to submit this pull request. Before we can merge it, we need you to sign our Contributor License Agreement (CLA). Can you please take care of it? |
Issue
#4136
Description
healthProbeBindAddr
as helm chart value--health-probe-bind-addr
toargs:
indeployment.yaml
readinessProbe
andlivenessProbe
healthProbeBindAddr
totest.yaml
healthProbeBindAddr
readinessProbe
livenessProbe
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯