Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parallelise image build process #342

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: parallelise image build process #342

wants to merge 6 commits into from

Conversation

jokestax
Copy link
Contributor

@jokestax jokestax commented Jan 19, 2025 •
edited by aryan9600
Loading

Description

Splits the image build process into separate jobs for amd64 and arm64,
enabling parallel execution in CI pipelines.

fixes #321

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2025
@jokestax jokestax mentioned this pull request Jan 19, 2025
Open
aryan9600
aryan9600 reviewed Jan 19, 2025
View reviewed changes
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@jokestax jokestax requested a review from aryan9600 January 19, 2025 16:01
@jokestax jokestax requested a review from shaneutt January 25, 2025 08:02
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@shaneutt shaneutt added tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. labels Jan 28, 2025
@shaneutt
Copy link
Member

shaneutt commented Feb 3, 2025

Hey @jokestax 👋

Just checking in. Are things going OK? Need any help with anything?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2025
@jokestax
Copy link
Contributor Author

jokestax commented Feb 9, 2025

Hi @shaneutt , how are you? I've resolved all the comments and also took care of the merge conflicts. Apologies for the late reply! Let me know if anything else needs attention.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2025
@shaneutt
Copy link
Member

Hi @shaneutt , how are you? I've resolved all the comments and also took care of the merge conflicts. Apologies for the late reply! Let me know if anything else needs attention.

Doing well thanks! We are all volunteers on this project so no apology is necessary in the least, just wanted to check in and see if there's any help that was needed.

Looks like we're just about ready, but there is one more merge conflict to resolve!

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2025
@jokestax
Copy link
Contributor Author

Done ✅

@shaneutt shaneutt self-assigned this Feb 12, 2025
shaneutt
shaneutt approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jokestax!

/approve

Will defer to @aryan9600 for final LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jokestax, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@astoycos astoycos Awaiting requested review from astoycos

@aryan9600 aryan9600 Awaiting requested review from aryan9600

Assignees

@shaneutt shaneutt

@aryan9600 aryan9600

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Blixt Project Board
Status: Review
Milestone
v0.4.0 - Rewrite of the control-plane...
Development

Successfully merging this pull request may close these issues.

Multi-arch container builds are having some trouble
4 participants
@jokestax @shaneutt @k8s-ci-robot @aryan9600