Update Gateway CRDs to v1.5.0#411
Conversation
Updates the Gateway API CRDs from version v1.4.1 to v1.5.0 using: ``` GIT_VERSION=v1.5.0 ./hack/download-gateway-crds.sh ``` Notes for reviewers ------------------- It's unclear what the policy is around when cloud-provider-kind upgrades its Gateway CRDs as new versions of Kubernetes Gateway API come out. The only info I found on why past upgrades of these CRDs have happened seems to be in the prior PR kubernetes-sigs#372 which seems to have been motivated by "unit tests fail [due to an upstream change] if you do not update the generated code to the latest". This PR is not motivated by broken tests, it's motivated by a desire for `cloud-provider-kind` to not fail when attempting to use a more recent version of the Gateway CRDs in Kind. If you spin up a fresh kind cluster today, then apply the v1.5.0 CRDs to that cluster, then attempt to run `cloud-provider-kind` (hereafter "CPK"), then CPK will fail due to a version mismatch. The only fix is to locally build a version of CPK which includes version 1.5.0 of the Gateway CRDs. Steps to reproduce using commit `3392ee06aac6fcac4817f92a1aafcdb9787a51f6` of CPK: ``` ./kind create cluster kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.5.0/standard-install.yaml cloud-provider-kind ``` Fails with: ``` E0512 15:54:03.456491 1063399 controller.go:294] "Failed to install Gateway API CRDs" err="error processing embedded CRDs from crds/standard: failed to create CRD \"backendtlspolicies.gateway.networking.k8s.io\" from file \"crds/standard/gateway.networking.k8s.io_backendtlspolicies.yaml\": customresourcedefinitions.apiextensions.k8s.io \"backendtlspolicies.gateway.networking.k8s.io\" is forbidden: ValidatingAdmissionPolicy 'safe-upgrades.gateway.networking.k8s.io' with binding 'safe-upgrades.gateway.networking.k8s.io' denied request: Installing CRDs with version before v1.5.0 is prohibited by default. Uninstall ValidatingAdmissionPolicy safe-upgrades.gateway.networking.k8s.io to install older versions." ``` Additionally, a prior change has already upgraded the Go dependency for gateway-api to v1.5.1, implying that this upgrade should have already happened but may have been overlooked. Change was in kubernetes-sigs#386 -------------- If this is not the right time to do this upgrade, or if this change is not in line with the contributing guidelines, then please close this PR. I'm just trying to be proactive about the version upgrades.
|
|
|
Welcome @lelandbatey! |
k8s-ci-robot
added
cncf-cla: no
|
Hi @lelandbatey. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/L
|
awesome /ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, lelandbatey The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
Updates the Gateway API CRDs from version v1.4.1 to v1.5.0 using:
Notes for reviewers
It's unclear what the policy is around when cloud-provider-kind upgrades its Gateway CRDs as new versions of Kubernetes Gateway API come out. The only info I found on why past upgrades of these CRDs have happened seems to be in the prior PR #372 which seems to have been motivated by "unit tests fail [due to an upstream change] if you do not update the generated code to the latest".
This PR is not motivated by broken tests, it's motivated by a desire for
cloud-provider-kind(hereafter "CPK") to not fail when attempting to use a more recent version of the Gateway CRDs in Kind. If you spin up a fresh kind cluster today, then apply the v1.5.0 CRDs to that cluster, then attempt to runcloud-provider-kind, then CPK will fail due to a version mismatch. The only fix is to locally build a version of CPK which includes version 1.5.0 of the Gateway CRDs. Steps to reproduce using commit3392ee06aac6fcac4817f92a1aafcdb9787a51f6of CPK:Fails with:
Additionally, a prior change has already upgraded the Go dependency for gateway-api to v1.5.1, implying that this upgrade should have already happened but may have been overlooked. Change was in #386
If this is not the right time to do this upgrade, or if this change is not in line with the contributing guidelines, then please close this PR. I'm just trying to be proactive about the version upgrades.