Skip to content

🌱 Implement healthz and readyz checks in the deployment #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

🌱 Implement healthz and readyz checks in the deployment #666

merged 1 commit into from
Dec 20, 2024

Conversation

@Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Dec 20, 2024

What this PR does / why we need it:

This change standardizes health check endpoint to use default port of :9440.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2024
@netlify
Copy link

netlify bot commented Dec 20, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit fdd8506
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/676595337516e40008098192
😎 Deploy Preview https://deploy-preview-666--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Dec 20, 2024

This needs rebase after #665

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
furkatgofurov7
furkatgofurov7 reviewed Dec 20, 2024
View reviewed changes
furkatgofurov7
furkatgofurov7 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2024

LGTM label has been added.

Git tree hash: f93b86c7a41580e2ea80c61158bdc1a860e5c597

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Dec 20, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Dec 20, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit c8d1281 into kubernetes-sigs:main Dec 20, 2024
14 checks passed
@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Dec 24, 2024

/cherry-pick release-0.15

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Dec 24, 2024

@furkatgofurov7: new pull request created: #671

In response to this:

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@damdo damdo Awaiting requested review from damdo

Assignees

@furkatgofurov7 furkatgofurov7

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Danil-Grigorev @furkatgofurov7 @k8s-ci-robot @k8s-infra-cherrypick-robot