✨ Make configSecret configurable per component

[rbjorklin]

What this PR does / why we need it:
This builds on the extensibility introduced in #638.

• This makes the connection between the configSecret and the component/provider using said config clearer.
• Reduces duplication of the configSecret logic across templates by moving it into a helper.
• Adds the ability to configure fetchConfig.

This has been implemented in such a way that it is backwards compatible and will default to the existing behaviour. If you want to use the new behaviour you would have to do something like this:

core:
  cluster-api:
    version: v1.9.6
    configSecret:
      name: my-custom-core-config
      namespace: capi-system

infrastructure:
  azure:
    namespace: capz-system
    version: v1.19.1
    configSecret:
      name: azure-variables
      namespace: capz-system

while also removing the configSecret key at the root level of the values.yaml file.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Hi @rbjorklin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name	Link
🔨 Latest commit	4fdac3e
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-operator/deploys/68c1f675e545600008924389
😎 Deploy Preview	https://deploy-preview-780--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[dmvolod]

/ok-to-test

[sathieu]

@rbjorklin Thanks for this. Following the same idea, can you add fetchConfig, manager.featureGates, additionalDeployments, manifestPatches, and additionalManifests configurable per provider?

[rbjorklin]

@rbjorklin Thanks for this. Following the same idea, can you add fetchConfig, manager.featureGates, additionalDeployments, manifestPatches, and additionalManifests configurable per provider?

manifestPatches and additionalManifests were already implemented in the referenced PR #638. I'll see if I can get the others added though.

[bsctl]

@rbjorklin @sathieu what's about to merge these PR #780 and leave open other PRs for the remaining fetchConfig, manager.featureGates, additionalDeployments ?

[sathieu]

@bsctl I've moved to another way of managing providers (here) and I'm no longer interrested in this PR.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[rbjorklin]

Just rebased and added fetchConfig. Is there a maintainer that could review this?

[rbjorklin]

/retest-required

[rbjorklin]

Alright, I think I've got the tests sorted now. This just needs a review.

[alexander-demicev]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexander-demicev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alexander-demicev]

@rbjorklin The PR looks good, I approved it. Can I ask you to take a look at this one #832? It might affect your deployment.

[rbjorklin]

@rbjorklin The PR looks good, I approved it. Can I ask you to take a look at this one #832? It might affect your deployment.

Thanks for the pointer @alexander-demicev! The author of #832 takes greater picture approach and also adds configSecret in a very similar way to mine. Would be happy to endorse #832 over mine if that PR also gets fetchConfig support.

[furkatgofurov7]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: dbd6ef4d5f35751242d8d65b79a3d536f5dff005

[furkatgofurov7]

/retitle ✨ Make configSecret configurable per component