Skip to content

Conversation

@fariaass
Copy link
Contributor

@fariaass fariaass commented Aug 8, 2025

What this PR does / why we need it:
This PR adds the fields DiagnosticsAddress and InsecureDiagnostics to ControllerMetrics struct. It also configures these fields as flags in the deployment.
As of CAPI v1.9, the flag --metrics-bind-addr was removed, so the flag --diagnostics-address must be used in place.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: fariaass / name: Lucas de Farias Teixeira (7a74152)
  • ✅ login: furkatgofurov7 / name: Furkat Gofurov (c9d5d72)

@netlify
Copy link

netlify bot commented Aug 8, 2025

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit c9d5d72
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-operator/deploys/68de8a09e9de9a000882e190
😎 Deploy Preview https://deploy-preview-871--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @fariaass. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2025
@fariaass fariaass force-pushed the chore/implement-diagnostics-fields branch from cdf6910 to 641c65f Compare August 8, 2025 20:09
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 8, 2025
@furkatgofurov7
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2025
@furkatgofurov7
Copy link
Member

@fariaass can you run make generate and push any changes made after running it to current PR?

@furkatgofurov7 furkatgofurov7 force-pushed the chore/implement-diagnostics-fields branch from 641c65f to 0013b46 Compare October 2, 2025 06:45
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@furkatgofurov7 furkatgofurov7 force-pushed the chore/implement-diagnostics-fields branch from 91fd71d to 7bef850 Compare October 2, 2025 10:12
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7 furkatgofurov7 force-pushed the chore/implement-diagnostics-fields branch from 7bef850 to c9d5d72 Compare October 2, 2025 14:19
@alexander-demicev
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3fd5a6460db480dcd722d59438c01a1b935df2ff

@k8s-ci-robot k8s-ci-robot merged commit d21153e into kubernetes-sigs:main Oct 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants