-
Notifications
You must be signed in to change notification settings - Fork 109
✨ Support alter components custom func #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support alter components custom func #876
Conversation
Signed-off-by: Carlos Salas <[email protected]>
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Carlos Salas <[email protected]>
e92b010 to
5b3b26b
Compare
|
@salasberryfin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
alexander-demicev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mjura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
furkatgofurov7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 214a74d5ac39af5d03dd0fa9e3c47cb457e4c6a1
|
What this PR does / why we need it:
With the recent changes in CAPI Operator that expose phase reconciliation, it would be great if we can also make applying changes on provider manifest definition easier during one of these phases.
This change introduces a new field in
PhaseReconcilerto embed one/multiple ComponentsAlterFn that are applied onFetch. With this solution, specific components on a provider's manifest definition can be patched based on the logic passed in this/these function/functions.Additionally, this adds an extra commit to fix a typo in one of the struct names
PhaseReconcilerOption. Looks like this is the reason CI's triggerring api diff issues, I can drop this change if it delays having the new feature added, and I can open a separate PR to fix the typo.Which issue(s) this PR fixes:
Fixes #