Skip to content

Conversation

@salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Aug 19, 2025

What this PR does / why we need it:

With the recent changes in CAPI Operator that expose phase reconciliation, it would be great if we can also make applying changes on provider manifest definition easier during one of these phases.

This change introduces a new field in PhaseReconciler to embed one/multiple ComponentsAlterFn that are applied on Fetch. With this solution, specific components on a provider's manifest definition can be patched based on the logic passed in this/these function/functions.

Additionally, this adds an extra commit to fix a typo in one of the struct names PhaseReconcilerOption. Looks like this is the reason CI's triggerring api diff issues, I can drop this change if it delays having the new feature added, and I can open a separate PR to fix the typo.

Which issue(s) this PR fixes:
Fixes #

@netlify
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit 5b3b26b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-operator/deploys/68a482400e838a00083d99ec
😎 Deploy Preview https://deploy-preview-876--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2025
@salasberryfin salasberryfin force-pushed the support-alter-components-custom-func branch from e92b010 to 5b3b26b Compare August 19, 2025 13:55
@k8s-ci-robot
Copy link
Contributor

@salasberryfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-operator-apidiff-main 5b3b26b link false /test pull-cluster-api-operator-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@salasberryfin salasberryfin moved this to PR to be reviewed in CAPI / Turtles Aug 19, 2025
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 214a74d5ac39af5d03dd0fa9e3c47cb457e4c6a1

@k8s-ci-robot k8s-ci-robot merged commit 3846d87 into kubernetes-sigs:main Aug 20, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from PR to be reviewed to Done in CAPI / Turtles Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants