Skip to content

📖 ROSA HCP IAM Roles proposal #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

📖 ROSA HCP IAM Roles proposal #5451

wants to merge 1 commit into from

Conversation

serngawy
Copy link
Contributor

@serngawy serngawy commented Mar 28, 2025 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Mar 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 28, 2025
@serngawy
Copy link
Contributor Author

serngawy commented Mar 28, 2025 •
edited
Loading

/cc @PanSpagetka

@k8s-ci-robot
Copy link
Contributor

@serngawy: GitHub didn't allow me to assign the following users: PanSpagetka.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @PanSpagetka

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serngawy serngawy force-pushed the rosa-iam branch 3 times, most recently from ffa2a6d to 52c3652 Compare April 2, 2025 15:59
nrb
nrb reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions and a couple nitpicks for style consistency, but overall I'm happy to approve this once those are addressed.

docs/proposal/20250324-rosa-iam-roles.md Outdated
- Reduce operational overhead for users deploying OpenShift ROSA HCP clusters on AWS via CAPA.

### Non-Goals
- Replacing existing IAM management workflows outside of CAPA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to write outside of ROSA here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya , I will fix that.

@serngawy
ROSA-HCP IAM proposal
a51a79d 
Signed-off-by: serngawy <[email protected]>
@nrb
Copy link
Contributor

nrb commented May 21, 2025

/test pull-cluster-api-provider-aws-apidiff-main

@k8s-ci-robot
Copy link
Contributor

@serngawy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main a51a79d link false /test pull-cluster-api-provider-aws-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nrb
Copy link
Contributor

nrb commented May 27, 2025

The API diff failure is not relevant and not required.

@damdo could you please take a look?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb left review comments

@PanSpagetka PanSpagetka PanSpagetka approved these changes

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serngawy @k8s-ci-robot @nrb @PanSpagetka