feat: add NestedVirtualization to CPUOptions in v1beta1 and v1beta2 APIs (backport release-2.9)#5875
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jhjaggars. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Backport to release-2.9. Add CPUOptions struct (ConfidentialCompute + NestedVirtualization) as a native field in both v1beta1 and v1beta2 AWSMachineSpec and Instance, enabling HyperShift to set nested virtualization directly via the v1beta1 API without relying on the annotation-based restore pattern. - Add NestedVirtualizationPolicy type and NestedVirtualization field to CPUOptions in api/v1beta2/types.go - Add AWSConfidentialComputePolicy, NestedVirtualizationPolicy types and CPUOptions struct to api/v1beta1/types.go - Add CPUOptions field to AWSMachineSpec in api/v1beta1/awsmachine_types.go - Remove manual CPUOptions restore lines from v1beta1 conversion files now that CPUOptions is a native v1beta1 field (auto-generated conversion handles it) - Add NestedVirtualization switch in getInstanceCPUOptionsRequest() in instances.go, mapping to EC2 SDK NestedVirtualizationSpecification - Bump github.com/aws/aws-sdk-go-v2/service/ec2 to v1.288.0 for CpuOptionsRequest.NestedVirtualization support - Regenerate deepcopy, conversion, and CRD manifests Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
1202db9 to
3e8e2e8
Compare
Summary
Backport of #5874 to
release-2.9.NestedVirtualizationPolicytype andNestedVirtualizationfield toCPUOptionsinapi/v1beta2/types.goAWSConfidentialComputePolicy,NestedVirtualizationPolicytypes andCPUOptionsstruct as a native field inapi/v1beta1/types.goandapi/v1beta1/awsmachine_types.go, enabling consumers (e.g. HyperShift) to set CPU options directly via the v1beta1 API without relying on the annotation-based restore patternCPUOptionsrestore lines from v1beta1 conversion files — auto-generated conversion now handles the fieldNestedVirtualizationswitch ingetInstanceCPUOptionsRequest()mapping to EC2 SDKNestedVirtualizationSpecificationgithub.com/aws/aws-sdk-go-v2/service/ec2to v1.288.0 forCpuOptionsRequest.NestedVirtualizationsupportTest plan
make testpasses locallymake lintpasses with 0 issuesAWSMachineTemplatewithcpuOptions.nestedVirtualization: enabledaccepted by v1beta1 webhook🤖 Generated with Claude Code