✨ Add missing, desired routes during route table reconciliation - #6047
✨ Add missing, desired routes during route table reconciliation#6047AndiDog wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
b27b2aa to
179c5c0
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test pull-cluster-api-provider-aws-e2e |
|
/retest I'm looking at that flake/race separately |
What type of PR is this?
/kind feature
What this PR does / why we need it:
For bring-your-own VPCs that miss routes such as
0.0.0.0/0, CAPA should create the desired routes. Therefore I implemented creation, while previously the code only fixed mismatching, existing routes (update). I specifically did not implement full reconciliation, i.e. deletion, since that could be a breaking, dangerous change.This also includes an improvement for event/log formatting since
%scan't format a struct reasonably.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
AI Usage:
I used Claude to create a failing test, then to rewrite and simplify existing logic to do both create+update. Basically the same as I would've done on my own, plus human check all along the way.
Checklist:
Release note: