Skip to content

✨ support CPU options in machine pools - #6148

Draft
justinmir wants to merge 1 commit into
kubernetes-sigs:mainfrom
reddit:feature/awsmachinepool-nested-virtualization
Draft

✨ support CPU options in machine pools#6148
justinmir wants to merge 1 commit into
kubernetes-sigs:mainfrom
reddit:feature/awsmachinepool-nested-virtualization

Conversation

@justinmir

@justinmir justinmir commented Jul 22, 2026

Copy link
Copy Markdown

What type of PR is this?
/kind api-change

What this PR does / why we need it:

Expose CPU options on AWS launch templates so machine pools can configure nested virtualization and confidential compute. CPUOptions was already added to AWSMachine.spec.cpuOptions in #5874.

AI Usage:
Yes, GPT 5.6-Sol XHigh was used to write some of the code.

Checklist:

  • squashed commits
  • includes documentation
  • includes AI generated content
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add CPUOptions support to AWSMachinePool and AWSManagedMachinePool launch templates, enabling nested virtualization and AMD SEV-SNP configuration

@kubernetes-prow kubernetes-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 22, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from AndiDog July 22, 2026 22:35
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested a review from serngawy July 22, 2026 22:35
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @justinmir. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Expose CPU options on AWS launch templates so machine pools can configure nested virtualization and confidential compute. Include the options in launch template creation, observation, update detection, and v1beta1 round-trip conversion.

Signed-off-by: Justin Miron <justin.miron@reddit.com>
@justinmir
justinmir force-pushed the feature/awsmachinepool-nested-virtualization branch from e39305b to 5bc4f5a Compare July 22, 2026 22:44
@justinmir justinmir changed the title ✨ WIP: Support CPU options in machine pools ✨ support CPU options in machine pools Jul 22, 2026
@richardcase

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@justinmir: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e-blocking 5bc4f5a link true /test pull-cluster-api-provider-aws-e2e-blocking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants