✨ v1beta2 contract: define v1beta2 condition type and reason const - #6187
✨ v1beta2 contract: define v1beta2 condition type and reason const#6187andclt wants to merge 1 commit into
Conversation
kubernetes-prow
Bot
added
needs-ok-to-test
|
Hi @andclt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
andclt
changed the title
kubernetes-prow
Bot
added
the
cncf-cla: yes
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-prow
Bot
added
the
do-not-merge/release-note-label-needed
| AWSClusterLoadBalancerReadyCondition = "LoadBalancerReady" | ||
|
|
||
| // AWSClusterS3BucketReadyCondition reports on the successful reconciliation of an S3 bucket. | ||
| AWSClusterS3BucketReadyCondition = "S3BucketReady" |
There was a problem hiding this comment.
The old constant used S3BucketCreated, I've changed it to S3BucketReady for consistency
|
|
||
| // AWSClusterVpcEndpointsReadyCondition reports on the successful reconciliation of VPC endpoints. | ||
| // Only applicable to managed clusters. | ||
| AWSClusterVpcEndpointsReadyCondition = "VpcEndpointsReady" |
There was a problem hiding this comment.
the old constant used VpcEndpointsReadyCondition has value, dropped Condition suffix for consistency
|
/ok-to-test |
kubernetes-prow
Bot
added
ok-to-test
|
@andclt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Defines new v1beta2 condition type and reason constants as plain string type (not
clusterv1beta1.ConditionType) for use with[]metav1.Condition. This is part of CAPA's migration to the CAPI v1beta2 provider contract (Phase 1).New constants follow CAPV's naming convention:
{Resource}{ConditionName}Condition— e.g.AWSClusterVpcReadyCondition = "VpcReady"{Resource}ReadyCondition = clusterv1.ReadyConditionclusterv1.ReadyReason,clusterv1.NotReadyReason,clusterv1.DeletingReasonwhere applicable; provider-specific reasons as {Resource}{Reason}ReasonNew
v1beta2_condition_consts.gofiles are added in each API package covering all resources:AWSCluster,AWSMachine,AWSMachinePool,AWSManagedMachinePool,AWSFargateProfile,AWSManagedControlPlane,ROSAControlPlane,ROSAMachinePool,ROSACluster,ROSANetwork,ROSARoleConfig,ROSAOCMRoleConfig,EKSConfig, andNodeadmConfig.These constants are purely additive and sit alongside the existing
clusterv1beta1.ConditionTypeconstants. They will be consumed by controllers in a later sub-task (#6103: dual-write).Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6101
Special notes for your reviewer:
VpcEndpointsReadyConditionhad the string value with the suffixCondition("VpcEndpointsReadyCondition"). The new constant uses "VpcEndpointsReady".S3BucketReadyConditionused value"S3BucketCreated". The new constant uses"S3BucketReady".AI Usage:
Claude Code was used to assist with drafting the constant definitions and doc comments.
Checklist:
Release note:
release-note
Define v1beta2 condition type and reason constants for all CAPA provider resources, following CAPV's naming convention, as part of the CAPI v1beta2 contract migration.