-
Notifications
You must be signed in to change notification settings - Fork 447
Update dependencies using github actions #5636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
# Tools directory | ||
TOOLS_DIR := hack/tools | ||
TOOLS_BIN_DIR := $(abspath $(TOOLS_DIR)/bin) | ||
TOOLS_YAML := $(TOOLS_DIR)/tools.yaml | ||
ADDONS_DIR := templates/addons | ||
|
||
# Templates directory | ||
TEMPLATES_DIR := $(ROOT_DIR)/templates | ||
BIN_DIR := $(abspath $(ROOT_DIR)/bin) | ||
EXP_DIR := exp | ||
GO_INSTALL = ./scripts/go_install.sh | ||
E2E_DATA_DIR ?= $(ROOT_DIR)/test/e2e/data | ||
AZURE_TEMPLATES := $(E2E_DATA_DIR)/infrastructure-azure | ||
KUBETEST_CONF_PATH ?= $(abspath $(E2E_DATA_DIR)/kubetest/conformance.yaml) | ||
KUBETEST_WINDOWS_CONFIG ?= upstream-windows.yaml | ||
KUBETEST_WINDOWS_CONF_PATH ?= $(abspath $(E2E_DATA_DIR)/kubetest/$(KUBETEST_WINDOWS_CONFIG)) | ||
KUBETEST_REPO_LIST_PATH ?= $(abspath $(E2E_DATA_DIR)/kubetest/) | ||
AZURE_TEMPLATES := $(E2E_DATA_DIR)/infrastructure-azure | ||
ADDONS_DIR := templates/addons | ||
CONVERSION_VERIFIER := $(TOOLS_BIN_DIR)/conversion-verifier | ||
|
||
# Bin directory | ||
BIN_DIR := $(abspath $(ROOT_DIR)/bin) | ||
|
||
# Exp directory | ||
EXP_DIR := exp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is just reorganizing the Makefile.
/label tide/merge-method-squash |
Testing the workflow, will remove the latest commit before merging. |
- create individual PRs for each of the updated tool - envsubst is updated via go list instead of hack/tools/tools.yaml - adjust labels
/unhold |
Upon closer inspection, |
/test pull-cluster-api-provider-azure-e2e |
@nawazkh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
CONTROLLER_GEN
CONVERSION_GEN
KUSTOMIZE
AZWI
MOCKGEN
RELEASE_NOTES
KUBECTL
HELM
YQ
CODESPELL
[dependency] bump $tool to $latest"
hack/tools/tools.yaml
now becomes the source of truth for the versions of the tools consumed in CAPZ's Makefile (tools that cannot be updated via existing dependabot workflow).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #N/A
Special notes for your reviewer:
kustomize
,azwi
,kpromo
. Doing via GitHub action unifies the automation workflow and is also easier to maintain.Update Tool Versions
workflow can also be triggered manually.TODOs:
Release note: