-
Notifications
You must be signed in to change notification settings - Fork 36
Update docs for VPC integration #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishesh92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation for VPC integration in CloudStack clusters. It expands the existing network configuration instructions to include details on creating and managing VPC resources, adds CLI examples for listing VPCs, and provides a sample YAML configuration snippet to illustrate the setup.
Comments suppressed due to low confidence (1)
docs/book/src/clustercloudstack/configuration.md:76
- Verify that the jq filter '.vpc[]' correctly matches the output of 'cmk list vpcs'. If the output key is plural or different, update the filter for consistency.
cmk list vpcs listall=true zoneid=<zoneid> | jq '.vpc[] | {name, id}'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 25.66% 25.78% +0.11%
==========================================
Files 59 72 +13
Lines 5563 6778 +1215
==========================================
+ Hits 1428 1748 +320
- Misses 3996 4865 +869
- Partials 139 165 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a1cbed8
to
1a37e05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@kiranchavala
can you please have a look as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishesh92 In the network documentation section
Can we split the documentation for each network type in cloudstack with an example.
There are many variables which may cause some confusion.
CLOUDSTACK_NETWORK_NAME
CLOUDSTACK_VPC_NAME
with-existing-vpc-network
with-kube-vip
CLUSTER_ENDPOINT_IP
For example can we say
Currenty, there are 5 types of network in Cloudsack and provide the env value or sample yaml file detail for each network type
1. Isolated network
CLOUDSTACK_NETWORK_NAME
CLUSTER_ENDPOINT_IP=192.168.1.161
CLUSTER_ENDPOINT_PORT=6443
2. VPC network
CLOUDSTACK_VPC_NAME
CLOUDSTACK_NETWORK_NAME( tier name)
clusterctl generate
-- flavor with-existing-vpc-network
3. Shared network
CLOUDSTACK_NETWORK_NAME
4. Routed Isolated network
CLOUDSTACK_NETWORK_NAME
clusterctl generate
-- flavor with-existing-vpc-network
--flavor with-kube-vip \
5. Routed VPC network
CLOUDSTACK_VPC_NAME
CLOUDSTACK_NETWORK_NAME( tier name)
clusterctl generate
-- flavor with-existing-vpc-network
--flavor with-kube-vip \
@kiranchavala I have updated the docs a little bit. As of now, for using the flavor |
Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.