-
Notifications
You must be signed in to change notification settings - Fork 89
Update documentation for release process #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
cc @Prajyot-Parab |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@kishen-v, any update on this? |
Hey @Amulyam24 and @Karthik-K-N, We may need to hold this for a bit to add in more information. Thanks! |
5f8313b
to
d54f385
Compare
Hey @Prajyot-Parab @Amulyam24 @Karthik-K-N, |
/test pull-cluster-api-provider-ibmcloud-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @Amulyam24 and @Prajyot-Parab would be the right folks for review.
docs/book/src/developer/release.md
Outdated
- The status of the build jobs can be tracked from : https://prow.k8s.io/?job=post-cluster-api-provider-ibmcloud-push-images | ||
- The built images are available here: https://console.cloud.google.com/gcr/images/k8s-staging-capi-ibmcloud/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links do not appear as a hyperlink in the doc - https://deploy-preview-2223.cluster-api-ibmcloud.sigs.k8s.io/developer/release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that's the case with other links too. For eg:
https://deploy-preview-2223.cluster-api-ibmcloud.sigs.k8s.io/topics/vpc/uploading-an-image.html?highlight=https#add-vm-image-to-vpc
Should we consider taking it up in a separate issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, we can fix the hyperlinks as a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the above link is the only one that's not linked as such, I'll add the suggestion to this PR
Raised a separate PR for the same issue related to the above link that's not hyperlinked.
#2365
@kishen-v update release note in PR description. |
Hey @Prajyot-Parab, I've updated the release notes section, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @kishen-v!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, kishen-v, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR captures additional information associated with the release-process.
Special notes for your reviewer:
This is a initial set of steps identified for the release process. Please let me know if any section needs elaboration.
/area provider/ibmcloud
Release note: