Skip to content

🌱 Add nodeVolumeDetachTimeout & minReadySeconds for MD to RuntimeSDK e2e test template #10933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Aug 13, 2024
Merged

🌱 Add nodeVolumeDetachTimeout & minReadySeconds for MD to RuntimeSDK e2e test template #10933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...a/infrastructure-docker/main/cluster-template-upgrades-runtimesdk/cluster-runtimesdk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ spec:
- class: "default-worker"
name: "md-0"
nodeDeletionTimeout: "30s"
nodeVolumeDetachTimeout: "5m"
Copy link
Copy Markdown
Member

@fabriziopandini fabriziopandini Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: are we using volumes in this test?

Copy link
Copy Markdown
Contributor Author

@willie-yao willie-yao Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, just noticed that there was an inconsistency with how the template was updated, but it shouldn't actually affect the outcome of this test. I'll try and circle back on the actual source of the flake.

Copy link
Copy Markdown
Member

@sbueringer sbueringer Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we are not using them. But I think it doesn't hurt to have a bit more happy-path coverage here

minReadySeconds: 5
replicas: ${WORKER_MACHINE_COUNT}
failureDomain: fd4
machinePools:
Expand Down