✨ MachineHealthCheck supports checking Machine conditions

[justinmir]

What this PR does / why we need it:
MachineHealthCheck currently only allows checking Node conditions to validate if a machine is healthy. However, machine conditions capture conditions that do not exist on nodes, for example, control plane node conditions such as EtcdPodHealthy, SchedulerPodHealthy that can indicate if a controlplane machine has been created correctly.

Adding support for Machine conditions enables us to perform remediation during control plane upgrades.

This PR introduces a new fieldas part of the MachineHealthCheckSpec:
UnhealthyMachineConditions

This will mirror the behavior of UnhealthyNodeConditions but the MachineHealthCheck controller will instead check the machine conditions.

Which issue(s) this PR fixes:
Fixes #5450

Label(s) to be applied
/kind feature
/area machinehealthcheck

Notes for Reviewers
We updated the tests to validate the new MachineHealthCheck code paths for UnhealthyMachineConditions in the following ways:

• internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go includes a new envtest
• internal/controllers/machinehealthcheck/machinehealthcheck_targets_test.go includes a unit test that the machine will need remediation.
• Remaining test changes are boilerplate to ensure that this doesn't break existing functionality, everyplace we use UnhealthyNodeConditions we also specify a UnhealthyMachineConditions.
• Fuzz tests are updated for old APIs to drop the UnhealthyMachineConditions field since this is not specified in old APIs.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @justinmir!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @justinmir. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

/ok-to-test

[sbueringer]

Currently not enough bandwidth for a full review, but a few quick comments already:

• we should only add this to v1beta2
• we have to add this in a few places. I would recommend to rebase on top of main and search for all occurences of "nodeUnhealthyConditions" and check in which places we also need "unhealthyMachineConditions" (it will be in a lot of these cases :))

[justinmir]

/area machinehealthcheck

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

Sorry have to focus on finishing up v1beta2 in time for the upcoming release for a while. I'll try to get back to this afterwards

[fabriziopandini]

I will try to take a look in the next few days

[sbueringer]

@justinmir I now have finally bandwith to review this PR :). Could you plesae do another rebase before? Thank you!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[furkatgofurov7]

@justinmir hey, do you need any help with taking this PR forward and ready for review? It would be great to rebase and get early reviews from maintainers if you have time.

[sbueringer]

Thx for working on this so far!

/close
In favor of #12827

[k8s-ci-robot]

@sbueringer: Closed this PR.

Details

In response to this:

Thx for working on this so far!

/close
In favor of #12827

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.