Skip to content

Conversation

@vknabel
Copy link

@vknabel vknabel commented Nov 4, 2025

What this PR does / why we need it:
Currently e2e.ClusterUpgradeConformanceSpec always requires an existing KUBETEST_CONFIGURATION file path even if SkipConformanceTests is true.
This PR adds a condition to skip these Expects.

In the testing pipeline for our infrastructure provider we rely on sonobuoy instead of kubetest and therefore don't even need a kubetest config.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Nov 4, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vknabel / name: Valentin Knabel (4759d95)

@k8s-ci-robot
Copy link
Contributor

Welcome @vknabel!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vknabel. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vknabel vknabel changed the title 🌱 Do not require kubetest configration if not needed 🐛 Do not require kubetest configration if not needed Nov 4, 2025
@vknabel vknabel changed the title 🐛 Do not require kubetest configration if not needed 🐛 E2E: Do not require kubetest configration if not needed Nov 4, 2025
@chrischdi
Copy link
Member

/ok-to-test

@vknabel you will need to solve the CLA issue.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2025
@vknabel
Copy link
Author

vknabel commented Nov 7, 2025

@chrischdi thx for having a look.
The CLA agreement is in internal progress at my company. It should be signed on monday.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main-gke

Even if conformance tests are skipped, the kubetest configuration is still required and expected to exist
@vknabel vknabel force-pushed the optional-skip-conformance-tests-variable branch from 6bcd0b1 to 4759d95 Compare November 11, 2025 13:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 11, 2025
@vknabel
Copy link
Author

vknabel commented Nov 11, 2025

FYI solved the CLA issue (though it required a push to trigger the CLA hook after signing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants