-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 E2E: Do not require kubetest configration if not needed #12948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🐛 E2E: Do not require kubetest configration if not needed #12948
Conversation
|
|
|
Welcome @vknabel! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @vknabel. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test @vknabel you will need to solve the CLA issue. |
|
@chrischdi thx for having a look. |
|
/test pull-cluster-api-e2e-main-gke |
Even if conformance tests are skipped, the kubetest configuration is still required and expected to exist
6bcd0b1 to
4759d95
Compare
|
FYI solved the CLA issue (though it required a push to trigger the CLA hook after signing) |
What this PR does / why we need it:
Currently
e2e.ClusterUpgradeConformanceSpecalways requires an existingKUBETEST_CONFIGURATIONfile path even ifSkipConformanceTestsistrue.This PR adds a condition to skip these
Expects.In the testing pipeline for our infrastructure provider we rely on sonobuoy instead of kubetest and therefore don't even need a kubetest config.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area e2e-testing