-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from gcr.io staging repo #10
base: main
Are you sure you want to change the base?
Move away from gcr.io staging repo #10
Conversation
Stage COSI image builds to registry.k8s.io instead of gcr.io. GCR is being deprecated and will be unavailable 18 Mar 2025. Signed-off-by: Blaine Gardner <[email protected]>
The gcr.io/k8s-testimages/gcb-docker-gcloud image used by COSI still doesn't have a non-deprecated image location. Update the TODO note with the latest info so it can be more easily tracked. Signed-off-by: Blaine Gardner <[email protected]>
Add a note to uses of gcr.io/distroless/static explaining that it isn't necessary to migrate gcr.io usage to artifact hub because the gcr.io/distroless/static image is migrated to be hosted by artifact hub. Signed-off-by: Blaine Gardner <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# TODO: currently gcr.io/k8s-testimages/gcb-docker-gcloud has not moved to Artifact Registry | ||
# gcr.io will be shut down 18 Mar 2025, and we need replacement before then. Latest info below: | ||
# https://github.com/kubernetes/test-infra/blob/master/images/gcb-docker-gcloud/cloudbuild.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still no replacement for gcr.io/k8s-testimages/gcb-docker-gcloud
. The best I can do now is update our TODO note with latest info and progress.
|
||
# gcr.io is deprecated, but gcr.io/distroless/static is hosted by artifact hub with the gcr.io path. | ||
# See: https://github.com/GoogleContainerTools/distroless/issues/1320 | ||
FROM gcr.io/distroless/static:nonroot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary to migrate this gcr.io
image for reason in comment. It seems good to have this note. I would probably forget and then do all my google searching again in 6 months without it.
REPO="gcr.io/k8s-staging-sig-storage" | ||
REPO="registry.k8s.io/k8s-staging-sig-storage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is going to work. registry.k8s.io doesn't have a web interface to browse images, but I can browse it with this: https://explore.ggcr.dev/?repo=registry.k8s.io
There is no k8s-staging-sig-storage
in that list. Only the non-staging sig-storage
repo. What are we supposed to do for staging images?
Stage COSI image builds to registry.k8s.io instead of gcr.io. GCR is
being deprecated and will be unavailable 18 Mar 2025.
The gcr.io/k8s-testimages/gcb-docker-gcloud image used by COSI still
doesn't have a non-deprecated image location. Update the TODO note with
the latest info so it can be more easily tracked.
Add a note to uses of gcr.io/distroless/static explaining that it isn't
necessary to migrate gcr.io usage to artifact hub because the
gcr.io/distroless/static image is migrated to be hosted by artifact hub.