Skip to content

chore: upgrade go version to 1.24.3 and golangci-lint to 2.1.6 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: upgrade go version to 1.24.3 and golangci-lint to 2.1.6 #204

wants to merge 2 commits into from
+41 −28

Conversation

slashpai
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slashpai
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2025
@slashpai
Copy link
Member Author

cc @RainbowMango

@slashpai slashpai mentioned this pull request May 17, 2025
Open
@RainbowMango
Copy link
Member

This is most likely duplicated with #203.

@slashpai
Copy link
Member Author

This is most likely duplicated with #203.

ok I didn't see that, I was updating prometheus-adapter so found need to update dependencies here as well.
In this PR I have updated go version as well bumped k8s dependencies to v0.33.1

@RainbowMango
Copy link
Member

Maybe you can help to review that PR, and after that the dependent bot can help to bump to 1.33.1, and then this PR can focus on prometheus-adapter thing.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2025
@slashpai
Copy link
Member Author

I will rebase to just update go

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2025
@slashpai slashpai changed the title chore: upgrade go version to 1.24.3 and k8s dependencies to v0.33.1 chore: upgrade go version to 1.24.3 and golangci-lint to 2.1.6 May 17, 2025
slashpai
slashpai commented May 17, 2025
View reviewed changes
.golangci.yml
@@ -1,8 +1,6 @@
run:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated file with migration command https://golangci-lint.run/product/migration-guide

@slashpai
make update-lint
4bef9bd 
Signed-off-by: Jayapriya Pai <[email protected]>
@slashpai
Copy link
Member Author

@RainbowMango PTAL

slashpai
slashpai commented May 19, 2025
View reviewed changes
Makefile
@@ -48,7 +48,7 @@ build-test-adapter: update-generated
# Format and lint
# ---------------

HAS_GOLANGCI_VERSION:=$(shell $(GOPATH)/bin/golangci-lint version --format=short)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--format=short flag doesn't exist

RainbowMango
RainbowMango reviewed May 20, 2025
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@RainbowMango RainbowMango

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slashpai @k8s-ci-robot @RainbowMango