doc: update the release-quickstart.sh to include the image tag for lora-syncer #1080
Conversation
|
|
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @Ruoyu-y! |
|
Hi @Ruoyu-y. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/approve This looks good, but hopefully @wangchen615's work on upstream vLLM makes the LoRA syncer obsolete! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, Ruoyu-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
@wangchen615 or @kfswain do you have an upstream PR or Issue that you can link to for the above work being referenced? |
hack/release-quickstart.sh
Outdated
| @@ -108,6 +108,9 @@ sed -i.bak -E "s|(llm-d/llm-d-inference-sim:)[^\"[:space:]]+|\1v${VLLM_SIM}|g" " | |||
| # Also change the imagePullPolicy from Always to IfNotPresent on lines containing the vLLM image. | |||
| sed -i.bak '/llm-d\/llm-d-inference-sim/{n;s/Always/IfNotPresent/;}' "$VLLM_SIM_DEPLOY" | |||
|
|
|||
| # Update the container tag for lora-syncer in all vLLM deployment manifests. | |||
| sed -i.bak -E "s|(us-central1-docker\.pkg\.dev/k8s-staging-images/gateway-api-inference-extension/lora-syncer:)[^\"[:space:]]+|\1${RELEASE_TAG}|g" "$VLLM_GPU_DEPLOY" "$VLLM_CPU_DEPLOY" "$VLLM_SIM_DEPLOY" | |||
There was a problem hiding this comment.
- The vllm sim does not contain the lora-syncer.
- The image registry and imagePullPolicy should also be updated to align with the other images.
There was a problem hiding this comment.
Gotcha. I remove the updates for vllm sim and add the updates for both image registry and imagePullPolicy. Please check the update.
But while testing the script, i found the CONFORMANCE_MANIFESTS="conformance/resources/manifests/manifests.yaml" file no longer exists in the repo, which will trigger some error while running the script.
Does this manifest file still exist in the repo? Do we still need to update it for the release?
…ra-syncer Signed-off-by: Ruoyu Ying <[email protected]>
Update the image tag for lora-syncer in the shell script according to release tag.