-
Notifications
You must be signed in to change notification settings - Fork 88
Reduced GPU requirements #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced GPU requirements #272
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anshuman-agarwala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @anshuman-agarwala! |
Hi @anshuman-agarwala. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -16,7 +16,7 @@ kind: Deployment | |||
metadata: | |||
name: vllm-llama2-7b-pool | |||
spec: | |||
replicas: 3 | |||
replicas: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with only 1 replica you cannot really see the benefits of the request scheduling algorithms. let's keep 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big plus 1 here. While I understand the desire to minimize the accelerator footprint of a getting started guide. Someone interested in an inference-tailored scheduling tool will have access to multiple accelerators to test this.
We should add comments clarifying why we are reducing the max-loras also. (L4s need this, but A100/H100s can go higher)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with ^. However, we need a simple mechanism, e.g. kustomize, to allow users to change the default 3
to 1
or any other value. I've been using 1
in my test/dev env and can at least see the LoRA load balancing for my single node kind cluster. For example, create a kustomization.yaml
file in pkg/manifests/vllm/
:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- deployment.yaml
replicas:
- name: vllm-llama2-7b-pool
count: 1
Run kubectl apply -k pkg/manifests/vllm/
and the vllm deployment will be run with 1 replica.
This PR and associated issue may no longer be required due to #259 (comment). I'm in the process of testing and will provide an update shortly. /hold |
Closing for now |
Fixes #253