Skip to content

docs: add concepts and definitions to README.md #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shaneutt
Copy link
Member

This adds concepts and definitions to the README.md which may be helpful for contributors.

(redo of #680)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain April 24, 2025 12:22
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2025
Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ad0069a
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/680b90cb4af0b100080b54b4
😎 Deploy Preview https://deploy-preview-734--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shaneutt shaneutt force-pushed the shaneutt/concepts-and-definitions-for-readme branch from 5049b32 to 6fb4cef Compare April 25, 2025 13:38
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2025
@shaneutt shaneutt force-pushed the shaneutt/concepts-and-definitions-for-readme branch from 6fb4cef to ad0069a Compare April 25, 2025 13:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 25, 2025
@shaneutt shaneutt requested a review from ahg-g April 25, 2025 13:40
@ahg-g
Copy link
Contributor

ahg-g commented Apr 25, 2025

/lgtm
/approve

Thanks Shane!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit b66a61c into kubernetes-sigs:main Apr 25, 2025
7 checks passed
@shaneutt shaneutt deleted the shaneutt/concepts-and-definitions-for-readme branch April 25, 2025 14:38
shmuelk added a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Apr 27, 2025
* main:
  fixing errors in new template & disabling the default blank template (kubernetes-sigs#742)
  Updating proposal directories to match their PR number (kubernetes-sigs#741)
  added a target dedicated for running unit-test only (kubernetes-sigs#739)
  Add unit tests for pod APIs under pkg/datastore (kubernetes-sigs#712)
  docs: add concepts and definitions to README.md (kubernetes-sigs#734)
  Update issue templates (kubernetes-sigs#738)
  Move filter and scorer plugins registration to a separate file (kubernetes-sigs#729)
  EPP: Update GetRandomPod() to return nil if no pods exist (kubernetes-sigs#731)
  filter irrelevant pod in pod_reconciler (kubernetes-sigs#696)
  scheduler refactoring (kubernetes-sigs#730)

# Conflicts:
#	pkg/epp/scheduling/plugins/picker.go
#	pkg/epp/scheduling/plugins/picker/random_picker.go
#	pkg/epp/scheduling/plugins/pickers/random.go
#	pkg/epp/scheduling/scheduler.go
#	pkg/epp/scheduling/scheduler_test.go
kaushikmitr pushed a commit to kaushikmitr/llm-instance-gateway that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants