Boilerplate verification to ensure LICENSE information is present #880

bharathbrat · 2025-05-28T08:42:35Z

Adds boilerplate verification to ensure LICENSE information is present wherever required.

This is copied from gateway-api repository: https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/boilerplate/boilerplate.py. Main modification was to trim skipped dirs or files from the original file. There are some I have left in because they look like generic folders.

Fixes: #848

… in turn calls verify-boilerplate.sh

k8s-ci-robot · 2025-05-28T08:42:44Z

Welcome @bharathbrat!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-05-28T08:42:44Z

Hi @bharathbrat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

linux-foundation-easycla · 2025-05-28T08:42:45Z

The committers listed above are authorized under a signed CLA.

✅ login: bharathbrat / name: Bharath Modhipalli (bf88981, 93e6e87, 2ba9a96, c51d0ae, 8b1d5a2, 0ef36a8, 27b73b2, 41c359e, 1310566, afd2642, b6d5003, 1533244, 281b689, 0135835, 6369613, 4d70093, 27a3dbb, 432c5a9, 10ecc2e, 9ca8b51, d683c35, 3043ba5, c770edd, 72577fa)

netlify · 2025-05-28T08:43:04Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`d683c35`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/683df271ad520d0008cf4c30
😎 Deploy Preview	https://deploy-preview-880--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

ahg-g · 2025-05-28T15:48:10Z

/ok-to-test

…itially

…ses some diff errors to show up when compared to .orig files

hack/boilerplate/boilerplate.py

nirrozenbaum

some files were copied from another repo and contain 2014/2015 year in their header.. should fix those

ahg-g · 2025-06-02T02:12:05Z

/retest

bharathbrat · 2025-06-02T05:31:47Z

I am a bit puzzled by the latest test failures here.

When I check locally these files pass:

> hack/verify-all.sh -v
Skipping hack/../hack/verify-all.sh
Verified 176 file headers match boilerplate
SUCCESS: hack/../hack/verify-boilerplate.sh 

All tests passed successfully.

Do the files under client-go get regenerated at build time? Wondering if that causes these failures.

nirrozenbaum · 2025-06-02T14:38:56Z

we should have one boilerplate for go files and one for go generated files (which we have).
the right thing is to modify in makefile (in generate target) the boilerplate file that is used instead of using it’s own file.

to be more concrete, I think hack/boilerplate.go should be removed, hack/boilerplate/boilerplate.gogenerate should be used in make generate as header file, and hack/boilerplate/boilerplate.go should keep the year

…d redundant source

robscott

Thanks @bharathbrat!

/lgtm

ahg-g · 2025-06-02T19:25:24Z

/approve

k8s-ci-robot · 2025-06-02T19:25:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, bharathbrat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…bernetes-sigs#880) * Copy boilerplate.py from gateway-api * Create boilerplate.generatego.txt * Create boilerplate.go.txt * Create boilerplate.py.txt * Create boilerplate.sh.txt * Create verify-boilerplate.sh * Create verify-all.sh * Create kube-env.sh * Update Makefile to run static analysis that calls verify-all.sh which in turn calls verify-boilerplate.sh * trim unrequired dirs and files from skipped list in boilerplate.py * Fix definition of verify-all.sh in the Makefile * Adding execute permissions for the verify-all and verify-boilerplate scripts * Adding execute permissions for boilerplate.py * Fixing all existing violations that boilerplate verification found initially * Adding some files to ignore list because modifying their licenses causes some diff errors to show up when compared to .orig files * Update boilerplate verification scripts license year to 2025 * Remove year from boilerplate template for update-codegen.sh * Add bin/kube_codegen.sh to skipped files for boilerplate verification * Switch go codegen to use boilerplate.generatego.txt and remove the old redundant source

bharathbrat added 11 commits May 22, 2025 00:08

Copy boilerplate.py from gateway-api

27b73b2

Create boilerplate.generatego.txt

27a3dbb

Create boilerplate.go.txt

8b1d5a2

Create boilerplate.py.txt

0ef36a8

Create boilerplate.sh.txt

2ba9a96

Create verify-boilerplate.sh

281b689

Create verify-all.sh

afd2642

Create kube-env.sh

0135835

Update Makefile to run static analysis that calls verify-all.sh which…

41c359e

… in turn calls verify-boilerplate.sh

Merge branch 'kubernetes-sigs:main' into boilerplate_verification

c770edd

trim unrequired dirs and files from skipped list in boilerplate.py

1533244

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2025

k8s-ci-robot requested review from Jeffwan and robscott May 28, 2025 08:42

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2025

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2025

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 28, 2025

bharathbrat marked this pull request as ready for review May 28, 2025 10:18

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2025

k8s-ci-robot requested a review from ahg-g May 28, 2025 10:19

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2025

Fix definition of verify-all.sh in the Makefile

6369613

Fixing all existing violations that boilerplate verification found in…

9ca8b51

…itially

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2025

bharathbrat added 2 commits May 30, 2025 19:58

Adding some files to ignore list because modifying their licenses cau…

93e6e87

…ses some diff errors to show up when compared to .orig files

Merge branch 'kubernetes-sigs:main' into boilerplate_verification

3043ba5

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 31, 2025

bharathbrat force-pushed the boilerplate_verification branch from 45ddaaa to 3043ba5 Compare May 31, 2025 03:45

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 31, 2025

nirrozenbaum reviewed May 31, 2025

View reviewed changes

hack/boilerplate/boilerplate.py Outdated Show resolved Hide resolved

nirrozenbaum reviewed May 31, 2025

View reviewed changes

Update boilerplate verification scripts license year to 2025

72577fa

Merge branch 'kubernetes-sigs:main' into boilerplate_verification

432c5a9

bharathbrat added 2 commits June 1, 2025 23:02

Remove year from boilerplate template for update-codegen.sh

1310566

Add bin/kube_codegen.sh to skipped files for boilerplate verification

4d70093

bharathbrat added 2 commits June 2, 2025 11:44

Merge branch 'kubernetes-sigs:main' into boilerplate_verification

10ecc2e

Switch go codegen to use boilerplate.generatego.txt and remove the ol…

d683c35

…d redundant source

robscott reviewed Jun 2, 2025

View reviewed changes

k8s-ci-robot assigned robscott Jun 2, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2025

k8s-ci-robot merged commit b54126f into kubernetes-sigs:main Jun 2, 2025
8 checks passed

nirrozenbaum mentioned this pull request Jun 3, 2025

fixed typo in makefile #913

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Boilerplate verification to ensure LICENSE information is present #880

Boilerplate verification to ensure LICENSE information is present #880

Uh oh!

bharathbrat commented May 28, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

linux-foundation-easycla bot commented May 28, 2025 •

edited

Loading

Uh oh!

netlify bot commented May 28, 2025 •

edited

Loading

Uh oh!

ahg-g commented May 28, 2025

Uh oh!

Uh oh!

nirrozenbaum left a comment

Uh oh!

ahg-g commented Jun 2, 2025

Uh oh!

bharathbrat commented Jun 2, 2025

Uh oh!

nirrozenbaum commented Jun 2, 2025

Uh oh!

robscott left a comment

Uh oh!

ahg-g commented Jun 2, 2025

Uh oh!

k8s-ci-robot commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Boilerplate verification to ensure LICENSE information is present #880

Boilerplate verification to ensure LICENSE information is present #880

Uh oh!

Conversation

bharathbrat commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

linux-foundation-easycla bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

ahg-g commented May 28, 2025

Uh oh!

Uh oh!

nirrozenbaum left a comment

Choose a reason for hiding this comment

Uh oh!

ahg-g commented Jun 2, 2025

Uh oh!

bharathbrat commented Jun 2, 2025

Uh oh!

nirrozenbaum commented Jun 2, 2025

Uh oh!

robscott left a comment

Choose a reason for hiding this comment

Uh oh!

ahg-g commented Jun 2, 2025

Uh oh!

k8s-ci-robot commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

bharathbrat commented May 28, 2025 •

edited

Loading

linux-foundation-easycla bot commented May 28, 2025 •

edited

Loading

netlify bot commented May 28, 2025 •

edited

Loading