Skip to content

Update the Cleanup section for Istio in Getting Started #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shotarok
Copy link
Contributor

@shotarok shotarok commented Jun 2, 2025

Resolves #896

This PR updates the Cleanup section for Istio in Getting Started. I attached the logs when I executed the commands with my cluster.

Details
$ ./istioctl uninstall -y --purge
All Istio resources will be pruned from the cluster

  Removed apps/v1, Kind=Deployment/istio-ingressgateway.istio-system.
  Removed apps/v1, Kind=Deployment/istiod.istio-system.
  Removed /v1, Kind=Service/istiod.istio-system.
  Removed /v1, Kind=ConfigMap/istio.istio-system.
  Removed /v1, Kind=ConfigMap/istio-sidecar-injector.istio-system.
  Removed /v1, Kind=Pod/istio-ingressgateway-7d467856b8-7rzvt.istio-system.
  Removed /v1, Kind=Pod/istiod-66b6b78b68-j8fc4.istio-system.
  Removed /v1, Kind=ServiceAccount/istio-ingressgateway-service-account.istio-system.
  Removed /v1, Kind=ServiceAccount/istio-reader-service-account.istio-system.
  Removed /v1, Kind=ServiceAccount/istiod.istio-system.
  Removed rbac.authorization.k8s.io/v1, Kind=RoleBinding/istio-ingressgateway-sds.istio-system.
  Removed rbac.authorization.k8s.io/v1, Kind=RoleBinding/istiod.istio-system.
  Removed rbac.authorization.k8s.io/v1, Kind=Role/istio-ingressgateway-sds.istio-system.
  Removed rbac.authorization.k8s.io/v1, Kind=Role/istiod.istio-system.
  Removed policy/v1, Kind=PodDisruptionBudget/istio-ingressgateway.istio-system.
  Removed policy/v1, Kind=PodDisruptionBudget/istiod.istio-system.
  Removed autoscaling/v2, Kind=HorizontalPodAutoscaler/istio-ingressgateway.istio-system.
  Removed autoscaling/v2, Kind=HorizontalPodAutoscaler/istiod.istio-system.
  Removed admissionregistration.k8s.io/v1, Kind=MutatingWebhookConfiguration/istio-revision-tag-default..
  Removed admissionregistration.k8s.io/v1, Kind=MutatingWebhookConfiguration/istio-sidecar-injector..
  Removed admissionregistration.k8s.io/v1, Kind=ValidatingWebhookConfiguration/istio-validator-istio-system..
  Removed admissionregistration.k8s.io/v1, Kind=ValidatingWebhookConfiguration/istiod-default-validator..
  Removed rbac.authorization.k8s.io/v1, Kind=ClusterRole/istio-reader-clusterrole-istio-system..
  Removed rbac.authorization.k8s.io/v1, Kind=ClusterRole/istiod-clusterrole-istio-system..
  Removed rbac.authorization.k8s.io/v1, Kind=ClusterRole/istiod-gateway-controller-istio-system..
  Removed rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding/istio-reader-clusterrole-istio-system..
  Removed rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding/istiod-clusterrole-istio-system..
  Removed rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding/istiod-gateway-controller-istio-system..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/authorizationpolicies.security.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/destinationrules.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/envoyfilters.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/gateways.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/peerauthentications.security.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/proxyconfigs.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/requestauthentications.security.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/serviceentries.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/sidecars.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/telemetries.telemetry.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/virtualservices.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/wasmplugins.extensions.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/workloadentries.networking.istio.io..
  Removed apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/workloadgroups.networking.istio.io..
✔ Uninstall complete

$ k delete ns istio-system
namespace "istio-system" deleted

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and Jeffwan June 2, 2025 04:45
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @shotarok. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2025
Copy link

netlify bot commented Jun 2, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit c52c192
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/683d2c5f3bb22400080c3d58
😎 Deploy Preview https://deploy-preview-906--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Jun 2, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jun 2, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, shotarok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit f1e8288 into kubernetes-sigs:main Jun 2, 2025
7 checks passed
irar2 pushed a commit to irar2/gateway-api-inference-extension that referenced this pull request Jun 3, 2025
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 3, 2025
@shotarok shotarok deleted the shotarok/quick-start-istio-cleanup branch June 3, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Quickstart Istio Clean-Up
3 participants