-
Notifications
You must be signed in to change notification settings - Fork 658
Issue-4087: Increase MaxItems for CACertificateRefs validation #4088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @root30. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: root30 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
/remove-lifecycle stale |
|
/ok-to-test |
snorwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @root30!
It sounds reasonable to give administrators a bit more flexibility in how they choose to split their trusted CA bundles across resources.
|
One think that worries me is the size of Gateway object and I'm fine with increasing the number but I'm worried that 32 is too much. |
|
@kl52752 how about increasing it to 16 as a compromise? 😉 |
|
yeah we can meet half way :) @youngnick @robscott do you have any concerns about increasing this limitation? |
fd2d310 to
e5f6bdc
Compare
What type of PR is this?
kind feature
What this PR does / why we need it:
Increase the number of allowed Certificate Authority references
Which issue(s) this PR fixes:
Fixes #4087
Does this PR introduce a user-facing change?: