Skip to content

Conversation

@root30
Copy link
Contributor

@root30 root30 commented Sep 15, 2025

What type of PR is this?
kind feature

What this PR does / why we need it:
Increase the number of allowed Certificate Authority references

Which issue(s) this PR fixes:

Fixes #4087

Does this PR introduce a user-facing change?:

Increase the number of allowed Certificate Authority references from `8` to `32`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @root30. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: root30
Once this PR has been reviewed and has the lgtm label, please assign shaneutt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2025
@snorwin
Copy link
Member

snorwin commented Dec 29, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2025
@snorwin
Copy link
Member

snorwin commented Dec 29, 2025

/cc @rikatz @kl52752

@snorwin
Copy link
Member

snorwin commented Dec 29, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2025
Copy link
Member

@snorwin snorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @root30!

It sounds reasonable to give administrators a bit more flexibility in how they choose to split their trusted CA bundles across resources.

@kl52752
Copy link
Contributor

kl52752 commented Jan 15, 2026

One think that worries me is the size of Gateway object and I'm fine with increasing the number but I'm worried that 32 is too much.
Frontend validation is set on gateway as Default value and per port overrides. We allows to set 64 per port overrides which equals Listeners max number. In worst case scenario will have 65 * 32 references which seams a lot.

@snorwin
Copy link
Member

snorwin commented Jan 15, 2026

@kl52752 how about increasing it to 16 as a compromise? 😉

@kl52752
Copy link
Contributor

kl52752 commented Jan 15, 2026

yeah we can meet half way :)

@youngnick @robscott do you have any concerns about increasing this limitation?

@root30 root30 force-pushed the issue-4087 branch 2 times, most recently from fd2d310 to e5f6bdc Compare January 22, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase the number of allowed Certificate Authority references

5 participants