Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GCE test code #193

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Refactor GCE test code #193

merged 3 commits into from
Sep 19, 2024

Conversation

sawsa307
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactor GCE test codes.

Which issue(s) this PR fixes:
None

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2024
@sawsa307
Copy link
Contributor Author

/assign @LiorLieberman
/assign @spencerhance

@sawsa307
Copy link
Contributor Author

/hold Wait until #191 gets merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2024
@sawsa307 sawsa307 mentioned this pull request Sep 16, 2024
Merged
LiorLieberman
LiorLieberman reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping me to lgtm after you rebase

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@LiorLieberman
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 17, 2024
@LiorLieberman
Copy link
Member

/approve

will leave @spencerhance to give the final lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@sawsa307
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
robscott
robscott reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sawsa307! Just a few questions, otherwise LGTM

pkg/i2gw/providers/gce/ir_converter_test.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/gce/ir_converter_test.go Show resolved Hide resolved
pkg/i2gw/providers/gce/ir_converter_test.go Outdated Show resolved Hide resolved
@sawsa307
Move functions in gce_extensions.go.
0c2e90c 
* Move functions in gce_extensions.go into ir/gateway_converter.go so
  these helper functions are eaiser to locate.
@sawsa307
Move test variables as const and var.
222ca0b
robscott
robscott approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sawsa307!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott, sawsa307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LiorLieberman,robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7803824 into kubernetes-sigs:main Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman left review comments

@robscott robscott robscott approved these changes

@levikobi levikobi Awaiting requested review from levikobi

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees

@robscott robscott

@spencerhance spencerhance

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sawsa307 @LiorLieberman @k8s-ci-robot @robscott @spencerhance