Skip to content

implementing backend-protocol#286

Open
eladmotola wants to merge 17 commits intokubernetes-sigs:mainfrom
eladmotola:feature/nginxingress-backend-protocol
Open

implementing backend-protocol#286
eladmotola wants to merge 17 commits intokubernetes-sigs:mainfrom
eladmotola:feature/nginxingress-backend-protocol

Conversation

@eladmotola
Copy link
Contributor

@eladmotola eladmotola commented Jan 2, 2026

What type of PR is this?
/kind feature

What this PR does / why we need it:
Implementing backend-protocol annotation for nginx ingress controller
I also had to implement grpc route in this pr

Which issue(s) this PR fixes:

Fixes #266

Does this PR introduce a user-facing change?:

Add initial support for GRPC Backend Protocol

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 2, 2026
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 2, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @eladmotola. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2026
Copy link
Contributor

@Stevenjin8 Stevenjin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. took a quick look at seems broadly what I was thinking. Will take a closer look next week.

@Stevenjin8
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2026
@eladmotola
Copy link
Contributor Author

@Stevenjin8 Hey
i made some changes
waiting for your review ^^

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026
@Stevenjin8
Copy link
Contributor

@eladmotola hey this is on my list

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2026
@Stevenjin8
Copy link
Contributor

trying this out rn

@eladmotola
Copy link
Contributor Author

Hey @Stevenjin8
I fixed the canary usecase

@Stevenjin8
Copy link
Contributor

@eladmotola I think I'm happy to LGTM it once you add a release not and remove the backendtls policy stuff.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
@eladmotola
Copy link
Contributor Author

Hey @Stevenjin8
let me know what i can do more to push this

thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eladmotola, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026
@Stevenjin8
Copy link
Contributor

Stevenjin8 commented Jan 28, 2026

@eladmotola Hey thanks for working through this with me. Its not completely flushed out, ( we still need to implement support for certain annotations), but I think its fine as is. For example, it wouldn't be too hard to also support canary for GRPCRoutes.

EDIT: reread the above messages and realized that you implemented canary for grpc route... my bad. Its been a long week.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2026
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 31, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2026
@eladmotola
Copy link
Contributor Author

Hey @Stevenjin8
how can i fix the ci? how can we push this pr?

@Stevenjin8
Copy link
Contributor

@eladmotola you can run 'make verify' locally to see what's going on. We're pretty strained on reviewers and we need two people to merge this PR. I'm pushing for it though!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ingress NGINX] Support backend protocol annotation

3 participants