Skip to content

feat: add session affinity support#310

Open
chakravardhan wants to merge 2 commits intokubernetes-sigs:mainfrom
chakravardhan:feature/session-affinity
Open

feat: add session affinity support#310
chakravardhan wants to merge 2 commits intokubernetes-sigs:mainfrom
chakravardhan:feature/session-affinity

Conversation

@chakravardhan
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

This PR implements support for Nginx session affinity annotations, mapping them to GKE's GCPBackendPolicy

Supported Annotations:

  • nginx.ingress.kubernetes.io/affinity: Maps cookie to GENERATED_COOKIE.
  • nginx.ingress.kubernetes.io/session-cookie-max-age: Maps to cookieTtlSec.

Dependencies

Verification

  • Unit Tests: Added TestGCEFeature in gce_converter_test.go

Limitations / Future Work

  • Affinity Mode: Strict "persistent" session affinity (strong affinity) support will be added later when the new GKE Gateway CRDs supporting this feature are available and integrated.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 20, 2026
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chakravardhan
Once this PR has been reviewed and has the lgtm label, please assign stevenjin8 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @chakravardhan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 20, 2026
@Stevenjin8
Copy link
Contributor

@chakravardhan not going look at the these PRs until the CORS on is merged.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@spencerhance
Copy link
Contributor

/cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants