feat: add session affinity support#310
feat: add session affinity support#310chakravardhan wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chakravardhan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @chakravardhan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@chakravardhan not going look at the these PRs until the CORS on is merged. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements support for Nginx session affinity annotations, mapping them to GKE's GCPBackendPolicy
Supported Annotations:
nginx.ingress.kubernetes.io/affinity: MapscookietoGENERATED_COOKIE.nginx.ingress.kubernetes.io/session-cookie-max-age: Maps tocookieTtlSec.Dependencies
Verification
TestGCEFeatureingce_converter_test.goLimitations / Future Work
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: