Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: omar <omar.hammami@solo.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: puertomontt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @puertomontt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| return filepath.Dir(goModPath) | ||
| } | ||
|
|
||
| func canonicalizeMultiDocYAML(t *testing.T, in []byte) []byte { |
There was a problem hiding this comment.
We've got integration tests in work, so we can probably do those tests here.
…o kgw-emit Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
|
@puertomontt could you add yourself to the owners file and agree to ingress2gateway/docs/emitters.md Lines 61 to 83 in 2802595 |
|
@puertomontt Also, it would be nice to add some e2e tests, but we can have that in another PR (sooner rather than later hopefully) |
Signed-off-by: omar <omar.hammami@solo.io>
|
The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing
|
What type of PR is this?
/kind feature
depends on #305
What this PR does / why we need it:
Add kgateway emitter.
Which issue(s) this PR fixes:
Fixes #260
Does this PR introduce a user-facing change?: