Skip to content

Feat cors eg#342

Closed
kkk777-7 wants to merge 2 commits intokubernetes-sigs:mainfrom
kkk777-7:feat-cors-eg
Closed

Feat cors eg#342
kkk777-7 wants to merge 2 commits intokubernetes-sigs:mainfrom
kkk777-7:feat-cors-eg

Conversation

@kkk777-7
Copy link
Member

@kkk777-7 kkk777-7 commented Feb 7, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:
Support CORS in the Envoy Gateway emitter.

Currently, Envoy Gateway GA supports CORS via CRD/SecurityPolicy.
So, when a user selects the Envoy Gateway emitter, it should generate CRD without requiring --allow-experimental-gw-api.
when user specify --allow-experimental-gw-api while selecting EG emitter, it will generate CORS filter. #303
Also In the future, once Gateway API GA supports CORS, the common emitter should take precedence and generate a CORS filter.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

support CORS feature in Envoy Gateway Emitter.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 7, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kkk777-7
Once this PR has been reviewed and has the lgtm label, please assign liorlieberman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2026
@Stevenjin8
Copy link
Contributor

@kkk777-7

CORS just became GA in Gateway API :)

https://gateway-api.sigs.k8s.io/reference/spec/#httpcorsfilter and gateway api 1.5 is coming out soon, so I think, if anything, we should have it always emit gwapi CORS Filter regardless of --allow-experimental.

@kkk777-7
Copy link
Member Author

kkk777-7 commented Feb 8, 2026

@Stevenjin8 thanks for comments!
that makes sense, so I close this PR :)

@kkk777-7 kkk777-7 closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants