Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kkk777-7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
CORS just became GA in Gateway API :) https://gateway-api.sigs.k8s.io/reference/spec/#httpcorsfilter and gateway api 1.5 is coming out soon, so I think, if anything, we should have it always emit gwapi CORS Filter regardless of --allow-experimental. |
|
@Stevenjin8 thanks for comments! |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support CORS in the Envoy Gateway emitter.
Currently, Envoy Gateway GA supports CORS via
CRD/SecurityPolicy.So, when a user selects the Envoy Gateway emitter, it should generate CRD without requiring
--allow-experimental-gw-api.when user specify
--allow-experimental-gw-apiwhile selecting EG emitter, it will generate CORS filter. #303Also In the future, once Gateway API GA supports CORS, the common emitter should take precedence and generate a CORS filter.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: