Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Expand KOWKNodeClass to Support Generic NodeClass for E2E tests #1963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Feb 5, 2025

Fixes #N/A

##Description**

This PR extends the current KowkNodeClass implementation in the E2Es to support cloudprovider defined NodeClass, allowing for more flexible and reusable test management across different cloud providers integration testing.

Changes

  • Added abstraction layer for provider-specific implementations
  • Updated node lifecycle handlers for generic support

How was this change tested?

  • make e2etests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: engedaam
Once this PR has been reviewed and has the lgtm label, please assign maciekpytel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2025
@engedaam engedaam changed the title Expand to use generic NodeClass test: Expand KOWKNodeClass to Support Generic NodeClass for E2E tests Feb 5, 2025
@engedaam engedaam force-pushed the support-imported-crds-for-e2etests branch from b1d1e29 to 0d7e287 Compare February 5, 2025 16:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13162260466

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 81.262%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/controller.go 2 71.65%
pkg/controllers/disruption/drift.go 2 89.66%
Totals Coverage Status
Change from base Build 13143266451: -0.07%
Covered Lines: 9129
Relevant Lines: 11234

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants