-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Ensure that we don't step the idle duration since this can cause the batcher to exit #1964
test: Ensure that we don't step the idle duration since this can cause the batcher to exit #1964
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
c030774
to
9a8036a
Compare
9a8036a
to
09819cc
Compare
/lgtm |
Pull Request Test Coverage Report for Build 13164379968Details
💛 - Coveralls |
Fixes #N/A
Description
This ensures that we don't trigger a 5s move on the batcher during testing since this is exactly the same as the idle duration and was causing flakes in testing like in https://github.com/kubernetes-sigs/karpenter/actions/runs/13143439974/attempts/1?pr=1950
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.