🌱 (chore): enable ginkgolinter forbid-spec-pollution to enforce isolated test specs

[kersten]

🌱 Enable ginkgolinter forbid-spec-pollution

This PR adds the following configuration to .golangci.yml:

linters-settings:
  ginkgolinter:
    forbid-spec-pollution: true

Enabling forbid-spec-pollution ensures all shared test state is scoped within BeforeEach or similar blocks, helping prevent flaky tests and improving test isolation in Ginkgo test suites.

[k8s-ci-robot]

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

/ok-to-test
/lgtm
/approve

[camilamacedo86]

/lgtm cancel
/approved cancel

See that this one is falling in the linter checks: https://github.com/kubernetes-sigs/kubebuilder/actions/runs/14126922651/job/39578281565?pr=4710

[kersten]

/lgtm cancel /approved cancel

See that this one is falling in the linter checks: https://github.com/kubernetes-sigs/kubebuilder/actions/runs/14126922651/job/39578281565?pr=4710

Hey @camilamacedo86,

we should wait for the other PRs to get merged, then I will rebase and the test should be green again 👍🏻

[camilamacedo86]

It seems to make sense to add this.
I'm fine moving forward with this one. Let's merge it and see if we encounter any issues down the line.

/ok-to-test
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kersten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment