Add containerd.runtime.extra_args configuration - #13365
Conversation
Signed-off-by: Leonidas Avdelas <avdelasleonidas@gmail.com>
|
|
|
Welcome @LoniasGR! |
|
Hi @LoniasGR. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LoniasGR The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR extends Kubespray’s containerd (v2+ CRI) config.toml template to support injecting additional per-runtime configuration fields (beyond runtime_type, base_runtime_spec, and .options) via a new runtime.extra_args mapping.
Changes:
- Add
runtime.extra_argsrendering intoconfig.toml.j2under each[...runtimes.<name>]stanza. - Support string/boolean/non-string values when rendering
runtime.extra_argsentries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {% if value is string %} | ||
| {{ key }} = "{{ value }}" | ||
| {% elif value is boolean %} | ||
| {{ key }} = {{ value | lower }} | ||
| {% else %} | ||
| {{ key }} = {{ value }} | ||
| {% endif %} |
There was a problem hiding this comment.
The same code block is used in lines 43-51 to detect the variable type, so i'm not sure these two should differ.
|
/ok-to-test |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the ability to configure containerd runtime options. Our main use case was to enable the
cgroup_writableoption, but I tried to generalize so that the rest of the options can be included.cgroups_writablespecifically is also relevant for KEP 5474 and is needed for running specific kinds of workloads in Kubernetes (in our case it was FreeIPA).Example of usage:
Which issue(s) this PR fixes:
Did not find any relevant issues.
Special notes for your reviewer:
containerd_extra_runtime_args.Does this PR introduce a user-facing change?: