Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add script for aks windows cluster #1405

Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 6, 2024

/kind feature

  • Add script to create an AKS cluster with windows node for testing. This is to replace the deprecated aks-engine cluster creation that's used today for windows tests.

part of #860

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from nilekhc and ritazh January 6, 2024 01:42
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97f9dec) 55.00% compared to head (a54afd0) 54.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   55.00%   54.92%   -0.09%     
==========================================
  Files          22       22              
  Lines        2327     2327              
==========================================
- Hits         1280     1278       -2     
- Misses        923      924       +1     
- Partials      124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aramase aramase force-pushed the aramase/f/aks_windows_testing branch 4 times, most recently from d618652 to 41e5675 Compare January 8, 2024 18:02
@aramase
Copy link
Member Author

aramase commented Jan 8, 2024

/test pull-secrets-store-csi-driver-e2e-windows-experimental

@aramase aramase force-pushed the aramase/f/aks_windows_testing branch from 41e5675 to f0835cd Compare January 8, 2024 18:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2024
@aramase aramase marked this pull request as ready for review January 8, 2024 19:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tam7t January 8, 2024 19:02
@aramase aramase force-pushed the aramase/f/aks_windows_testing branch from f0835cd to a54afd0 Compare January 8, 2024 19:11
@aramase
Copy link
Member Author

aramase commented Jan 8, 2024

I'll open a separate PR for the CVE patches to fix pull-secrets-store-csi-driver-image-scan

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 8, 2024

@aramase: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-csi-driver-image-scan a54afd0 link false /test pull-secrets-store-csi-driver-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nilekhc
Copy link
Contributor

nilekhc commented Jan 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 261fc40 into kubernetes-sigs:main Jan 8, 2024
24 of 25 checks passed
@aramase aramase deleted the aramase/f/aks_windows_testing branch January 8, 2024 20:20
k8s-ci-robot added a commit that referenced this pull request Jan 8, 2024
…upstream-release-1.4

Automated cherry pick of #1405: ci: add script for aks windows cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants