Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add govulncheck check and fix GO-2024-2687 #1496

Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Apr 15, 2024

/kind feature

  • add govulncheck PR gate
  • bump golang.org/x/net to v0.23.0+ to fix GO-2024-2687

Signed-off-by: Anish Ramasekar <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nilekhc and tam7t April 15, 2024 23:53
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.83%. Comparing base (bf86dbf) to head (0abfaa3).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
- Coverage   36.58%   35.83%   -0.76%     
==========================================
  Files          63       63              
  Lines        4532     3759     -773     
==========================================
- Hits         1658     1347     -311     
+ Misses       2730     2268     -462     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aramase aramase changed the title ci: add govulncheck ci: add govulncheck check and fix GO-2024-2687 Apr 15, 2024
@nilekhc
Copy link
Contributor

nilekhc commented Apr 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 205bb9e into kubernetes-sigs:main Apr 16, 2024
26 checks passed
@aramase aramase deleted the aramase/ci/add_govuln_check branch April 16, 2024 00:41
k8s-ci-robot added a commit that referenced this pull request Apr 17, 2024
…upstream-release-1.4

Automated cherry pick of #1496: ci: add govulncheck and fix GO-2024-2687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants