Skip to content

Conversation

@BhargaviGudi
Copy link
Contributor

@BhargaviGudi BhargaviGudi commented Sep 8, 2025

What type of PR is this?

/kind bug
/documentation

What this PR does / why we need it:

This PR updates the installation-usage.md documentation to clarify where the audit log file generated by the JsonEnricher is stored. Currently, the documentation does not make it clear that the log file is written to the node's file system (not inside the pod), which can lead to confusion for users monitoring audit logs.

Which issue(s) this PR fixes:

Fixes documentation inconsistency observed when enabling JsonEnricher in the Security Profiles Operator.
Fixes bug: https://issues.redhat.com/browse/OCPBUGS-59523

Does this PR have test?

N/A — documentation-only change.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 8, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2025

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BhargaviGudi
Once this PR has been reviewed and has the lgtm label, please assign ccojocar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @BhargaviGudi!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @BhargaviGudi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2025
@saschagrunert
Copy link
Member

@BhargaviGudi thank you for the PR! Please sign the CLA for this one.

@saschagrunert
Copy link
Member

/check-cla

@BhargaviGudi
Copy link
Contributor Author

I have signed CLA document as individual contributor and still observing failure in this PR as Missing CLA Authentication

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.56%. Comparing base (11d77f4) to head (783778f).
⚠️ Report is 1006 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2994       +/-   ##
===========================================
- Coverage   45.50%   26.56%   -18.95%     
===========================================
  Files          79      125       +46     
  Lines        7782    20921    +13139     
===========================================
+ Hits         3541     5557     +2016     
- Misses       4099    15080    +10981     
- Partials      142      284      +142     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saschagrunert
Copy link
Member

  • he email address for the commit (8890e3f) is not linked to the GitHub account, preventing the EasyCLA check.

Have you checked this comment?

The email address for the commit (8890e3f) is not linked to the GitHub account, preventing the EasyCLA check.

@BhargaviGudi BhargaviGudi marked this pull request as draft September 18, 2025 06:28
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2025
@BhargaviGudi BhargaviGudi marked this pull request as ready for review October 3, 2025 06:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2025
@ngopalak-redhat
Copy link
Contributor

/check-cla

1 similar comment
@saschagrunert
Copy link
Member

/check-cla

…ation

OCPBUGS-59523 - Update installation-usage.md to clarify audit log location

OCPBUGS-59523 - update code block language identifiers from bash to shell

OCPBUGS-59523 - replaced oc with kubectl

OCPBUGS-59523 - updated

Signed-off-by: Bhargavi Gudi <[email protected]>
@saschagrunert
Copy link
Member

/check-cla

@BhargaviGudi
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@BhargaviGudi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ngopalak-redhat
Copy link
Contributor

/check-cla

@BhargaviGudi
Copy link
Contributor Author

Closing this PR as I have created new PR to resolve EasyCLA authentication issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants