Skip to content

Add new AR Registries to experimental project #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2022
Merged

Add new AR Registries to experimental project #3956

merged 6 commits into from
Aug 11, 2022

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jul 12, 2022 •
edited
Loading

Part of #1343

/hold

We need to create the AR registries in k8s-artifacts-prod and grant IAM roles to k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com service account.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ labels Jul 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from thockin July 12, 2022 11:01
@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Jul 12, 2022
@upodroid upodroid changed the title Enable Promoting to AR Registries for releng images Test Promoting Images to AR Registries Jul 12, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2022
@upodroid
Copy link
Member Author

/cc @puerco

@k8s-ci-robot k8s-ci-robot requested a review from puerco July 12, 2022 16:19
This was referenced Jul 13, 2022
Closed
Closed
@ameukam
Copy link
Member

ameukam commented Aug 3, 2022 •
edited
Loading

/approve
leaving lgtm to @kubernetes/release-engineering

Update: #3968 is needed before we merge this.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2022
@puerco
Copy link
Member

puerco commented Aug 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@upodroid
Copy link
Member Author

upodroid commented Aug 9, 2022

thank you, @ameukam cancel the hold once the infra has been deployed

@dims
Copy link
Member

dims commented Aug 9, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid upodroid mentioned this pull request Aug 10, 2022
Merged
@upodroid upodroid changed the title Test Promoting Images to AR Registries Add new AR Registries to experimental project Aug 10, 2022
@upodroid
Copy link
Member Author

/hold cancel

Looks like the registries are up.

 REDACTED  MCW0CDP3YY  ~  ERROR  $  gcrane ls europe-west2-docker.pkg.dev/k8s-artifacts-prod/images
 REDACTED  MCW0CDP3YY  ~  $  gcrane ls europe-west1-docker.pkg.dev/k8s-artifacts-prod/images
 REDACTED  MCW0CDP3YY  ~  $  gcrane ls europe-west1-docker.pkg.dev/k8s-artifacts-prod/image
2022/08/10 20:23:23 No matching credentials were found for "europe-west1-docker.pkg.dev"
Error: GET https://europe-west1-docker.pkg.dev/v2/token?scope=repository%3Ak8s-artifacts-prod%2Fimage%3Apull&service=: DENIED: Permission "artifactregistry.repositories.downloadArtifacts" denied on resource "projects/k8s-artifacts-prod/locations/europe-west1/repositories/image" (or it may not exist)

Thanks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
ameukam
ameukam reviewed Aug 10, 2022
View reviewed changes
k8s.gcr.io/manifests/k8s-staging-experimental/promoter-manifest.yaml
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-north1-docker.pkg.dev/k8s-artifacts-prod/images/experimental
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-southeast1-docker.pkg.dev/k8s-artifacts-prod/images/experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upodroid this region don't exist.

 gcloud artifacts locations list --project k8s-artifacts-prod | grep 'europe-'
europe-central2
europe-north1
europe-southwest1
europe-west1
europe-west2
europe-west3
europe-west4
europe-west6
europe-west8
europe-west9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

/hold cancel

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 505d6c8 into kubernetes:main Aug 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@thockin thockin Awaiting requested review from thockin

@puerco puerco Awaiting requested review from puerco

Assignees

@dims dims

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/k8s.gcr.io Code in k8s.gcr.io/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@upodroid @ameukam @puerco @dims @k8s-ci-robot