Skip to content

k8s.gcr.io: Remove Artifact registry repositories #4090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2022
Merged

k8s.gcr.io: Remove Artifact registry repositories #4090

merged 1 commit into from
Aug 16, 2022

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 16, 2022

Follow-up of:

Remove Artifact Registry repositories as destination registries for the
image promoter. An issue with AR IAM block the image promotion
process.

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 16, 2022

cc @puerco

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from thockin August 16, 2022 21:40
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 16, 2022

We should look at a different approach about to test AR promotion process.

@puerco
Copy link
Member

puerco commented Aug 16, 2022 •
edited
Loading

Should we also remove the images from the manifest? If we run it l like this they are going to be promoted to GCR and not AR:

k8s.io/k8s.gcr.io/images/k8s-staging-experimental/images.yaml

Lines 1 to 56 in 6ca9ca5

- name: conformance
dmap:
"sha256:dc5f9bd524683846b3b6009d8e174baaa13891cac8885cb52b8ce44380cbeda9": ["v1.25.0-rc.0"]
"sha256:7e41917cdb57aadc2efa38e2ca02c49f400270fb0ab5a7bfd359ae812fac5df0": ["v1.26.0-alpha.0"]
- name: conformance-amd64
dmap:
"sha256:68814705d02da7df2466e9d21b5c1b1c028451ffe7a1d52940763220dc4c25a8": ["v1.25.0-rc.0"]
"sha256:9696cb8712e7b4cac7209f63405b19e395ea615026f749649da4f8665da55493": ["v1.26.0-alpha.0"]
- name: conformance-arm
dmap:
"sha256:5de7f03ca533d6fccfb3d8d8bb321918bf38e4ed0e82ab2ca68de58a3e399170": ["v1.25.0-rc.0"]
"sha256:3f8d8751089042124f1fd0786ad82f655c1700a03b0c1e71a687b41b9d1605a1": ["v1.26.0-alpha.0"]
- name: conformance-arm64
dmap:
"sha256:36af8159aa53f3bf471c4fbaccfd2a239547c8dad73c0977aa1f1f89733d42c0": ["v1.25.0-rc.0"]
"sha256:ca640277aa6e2046f22492128f31a684472947a0f3e74f2489ef5d8ca6829a14": ["v1.26.0-alpha.0"]
- name: conformance-ppc64le
dmap:
"sha256:48c27c4b7db4766f701b0cc34c0825251dfc628747c3637edde851eeb3f2117a": ["v1.25.0-rc.0"]
"sha256:263b29ecff24efcadb0cc2ff7c65f6e15f83126917d17694b3ec36cec3a764d9": ["v1.26.0-alpha.0"]
- name: conformance-s390x
dmap:
"sha256:287f0bee34c2e046edd1578d685734f29337ab7cf54bbeee1222c4c8ca35db96": ["v1.25.0-rc.0"]
"sha256:38337462db1637101c1ec1901ea514c628bbe3d9e4c2f531cdb8c253ceeefbc3": ["v1.26.0-alpha.0"]
- name: kube-apiserver
dmap:
"sha256:1489622d5af19e30e569e9be7c0398a7db852bca3507f04a72896c5005da0459": ["v1.25.0-rc.0"]
"sha256:f44a9f6c4bd23617ebc23e3c71c6be8a2f1e122e0c9cd759f4f53ac96dca6aba": ["v1.26.0-alpha.0"]
- name: kube-apiserver-amd64
dmap:
"sha256:c2a20161bd1b1c9e8f2b466f4e5f63f9de484feee813dba126585d39fccf67d3": ["v1.25.0-rc.0"]
"sha256:d5d408d2b96f4017df6b257d1203bb24ec0b9af298f0deedbc7b38f8205019ad": ["v1.26.0-alpha.0"]
- name: kube-apiserver-arm
dmap:
"sha256:c586b2e9c38a5ca1b22e00a152d110e97f6f686d38cd5f273f7d35792c8e0064": ["v1.25.0-rc.0"]
"sha256:c2c909bacae7ce6d23439ca5e11f3ce5b1075bfe5978692236126bbea7b6a618": ["v1.26.0-alpha.0"]
- name: kube-apiserver-arm64
dmap:
"sha256:ee3a704d0791cde192590b9dd94d94dcb276c902d98da53cc1391b77442b3890": ["v1.25.0-rc.0"]
"sha256:7956fa2cd23c3c0ef94fbecf1f8bc4046a31fb1ea3362461a596784d3e1e8e1c": ["v1.26.0-alpha.0"]
- name: kube-scheduler-arm
dmap:
"sha256:c6ccda7f8aaf346d00eeecf34c4adebb18e57a80ac15ea9a63168050637f1763": ["v1.25.0-rc.0"]
"sha256:2f5e5d3d8f8b7e2f80024b39fb9d770a47304a8560531acc2719d150627d2995": ["v1.26.0-alpha.0"]
- name: kube-scheduler-arm64
dmap:
"sha256:293e5457d0a874a027d9cc83052296aee4a9f99e14dc4e30cec2e42bcff1641d": ["v1.25.0-rc.0"]
"sha256:4a9ebabe9439d505de7432fc9d3798e005767a0b860c8ff3c031b0c1955b7962": ["v1.26.0-alpha.0"]
- name: kube-scheduler-ppc64le
dmap:
"sha256:7a7f3ac0489e6689051c8575ea09b54638ea23d5a9a5c0889f27ac9e9ce61f0b": ["v1.25.0-rc.0"]
"sha256:b82cc2923116ff015c8f72790cbae315a2ce4f4e296ed70682c593248e926a49": ["v1.26.0-alpha.0"]
- name: kube-scheduler-s390x
dmap:
"sha256:9d1e355a9e8210fb285e8205ef75b31de43a6061d4e7c03bb15fcddce15bd703": ["v1.25.0-rc.0"]
"sha256:d44ac65f29d215ba115eaa5074a289086349edb4c01655b8f7d820507d4faf40": ["v1.26.0-alpha.0"]

@ameukam
k8s.gcr.io: Remove Artifact registry repositories
0a02403 
Remove Artifact Registry repositories as destination registries for the
image promoter. An issue AR IAM permissions block the image promotion
process.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam force-pushed the remove-ar-registry branch from 772321f to 0a02403 Compare August 16, 2022 21:49
@ameukam
Copy link
Member Author

ameukam commented Aug 16, 2022

Should we te also remove the images from the manifest? If we run it l like this they are going to be promoted to GCR and not AR:

k8s.io/k8s.gcr.io/images/k8s-staging-experimental/images.yaml

Lines 1 to 56 in 6ca9ca5

- name: conformance
dmap:
"sha256:dc5f9bd524683846b3b6009d8e174baaa13891cac8885cb52b8ce44380cbeda9": ["v1.25.0-rc.0"]
"sha256:7e41917cdb57aadc2efa38e2ca02c49f400270fb0ab5a7bfd359ae812fac5df0": ["v1.26.0-alpha.0"]
- name: conformance-amd64
dmap:
"sha256:68814705d02da7df2466e9d21b5c1b1c028451ffe7a1d52940763220dc4c25a8": ["v1.25.0-rc.0"]
"sha256:9696cb8712e7b4cac7209f63405b19e395ea615026f749649da4f8665da55493": ["v1.26.0-alpha.0"]
- name: conformance-arm
dmap:
"sha256:5de7f03ca533d6fccfb3d8d8bb321918bf38e4ed0e82ab2ca68de58a3e399170": ["v1.25.0-rc.0"]
"sha256:3f8d8751089042124f1fd0786ad82f655c1700a03b0c1e71a687b41b9d1605a1": ["v1.26.0-alpha.0"]
- name: conformance-arm64
dmap:
"sha256:36af8159aa53f3bf471c4fbaccfd2a239547c8dad73c0977aa1f1f89733d42c0": ["v1.25.0-rc.0"]
"sha256:ca640277aa6e2046f22492128f31a684472947a0f3e74f2489ef5d8ca6829a14": ["v1.26.0-alpha.0"]
- name: conformance-ppc64le
dmap:
"sha256:48c27c4b7db4766f701b0cc34c0825251dfc628747c3637edde851eeb3f2117a": ["v1.25.0-rc.0"]
"sha256:263b29ecff24efcadb0cc2ff7c65f6e15f83126917d17694b3ec36cec3a764d9": ["v1.26.0-alpha.0"]
- name: conformance-s390x
dmap:
"sha256:287f0bee34c2e046edd1578d685734f29337ab7cf54bbeee1222c4c8ca35db96": ["v1.25.0-rc.0"]
"sha256:38337462db1637101c1ec1901ea514c628bbe3d9e4c2f531cdb8c253ceeefbc3": ["v1.26.0-alpha.0"]
- name: kube-apiserver
dmap:
"sha256:1489622d5af19e30e569e9be7c0398a7db852bca3507f04a72896c5005da0459": ["v1.25.0-rc.0"]
"sha256:f44a9f6c4bd23617ebc23e3c71c6be8a2f1e122e0c9cd759f4f53ac96dca6aba": ["v1.26.0-alpha.0"]
- name: kube-apiserver-amd64
dmap:
"sha256:c2a20161bd1b1c9e8f2b466f4e5f63f9de484feee813dba126585d39fccf67d3": ["v1.25.0-rc.0"]
"sha256:d5d408d2b96f4017df6b257d1203bb24ec0b9af298f0deedbc7b38f8205019ad": ["v1.26.0-alpha.0"]
- name: kube-apiserver-arm
dmap:
"sha256:c586b2e9c38a5ca1b22e00a152d110e97f6f686d38cd5f273f7d35792c8e0064": ["v1.25.0-rc.0"]
"sha256:c2c909bacae7ce6d23439ca5e11f3ce5b1075bfe5978692236126bbea7b6a618": ["v1.26.0-alpha.0"]
- name: kube-apiserver-arm64
dmap:
"sha256:ee3a704d0791cde192590b9dd94d94dcb276c902d98da53cc1391b77442b3890": ["v1.25.0-rc.0"]
"sha256:7956fa2cd23c3c0ef94fbecf1f8bc4046a31fb1ea3362461a596784d3e1e8e1c": ["v1.26.0-alpha.0"]
- name: kube-scheduler-arm
dmap:
"sha256:c6ccda7f8aaf346d00eeecf34c4adebb18e57a80ac15ea9a63168050637f1763": ["v1.25.0-rc.0"]
"sha256:2f5e5d3d8f8b7e2f80024b39fb9d770a47304a8560531acc2719d150627d2995": ["v1.26.0-alpha.0"]
- name: kube-scheduler-arm64
dmap:
"sha256:293e5457d0a874a027d9cc83052296aee4a9f99e14dc4e30cec2e42bcff1641d": ["v1.25.0-rc.0"]
"sha256:4a9ebabe9439d505de7432fc9d3798e005767a0b860c8ff3c031b0c1955b7962": ["v1.26.0-alpha.0"]
- name: kube-scheduler-ppc64le
dmap:
"sha256:7a7f3ac0489e6689051c8575ea09b54638ea23d5a9a5c0889f27ac9e9ce61f0b": ["v1.25.0-rc.0"]
"sha256:b82cc2923116ff015c8f72790cbae315a2ce4f4e296ed70682c593248e926a49": ["v1.26.0-alpha.0"]
- name: kube-scheduler-s390x
dmap:
"sha256:9d1e355a9e8210fb285e8205ef75b31de43a6061d4e7c03bb15fcddce15bd703": ["v1.25.0-rc.0"]
"sha256:d44ac65f29d215ba115eaa5074a289086349edb4c01655b8f7d820507d4faf40": ["v1.26.0-alpha.0"]

@puerco Done.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2022
@puerco
Copy link
Member

puerco commented Aug 16, 2022

Awesome, let's kick it 🚀
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@puerco
Copy link
Member

puerco commented Aug 16, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2b15e52 into kubernetes:main Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin Awaiting requested review from thockin

Assignees

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @puerco @k8s-ci-robot