-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the new registry for archeio #7759
use the new registry for archeio #7759
Conversation
Ran Plan for dir: Show OutputNote: Objects have changed outside of Terraform
Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:
# module.artifact_registry["charts"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/charts"
name = "charts"
~ update_time = "2025-02-03T16:30:11.067952Z" -> "2025-02-05T15:26:05.661657Z"
# (12 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["cloud-provider-kind"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/cloud-provider-kind"
name = "cloud-provider-kind"
~ update_time = "2025-01-30T20:48:04.482588Z" -> "2025-02-05T17:50:42.641438Z"
# (12 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/gateway-api-inference-extension"
name = "gateway-api-inference-extension"
~ update_time = "2025-02-03T18:52:32.641052Z" -> "2025-02-04T22:22:50.152478Z"
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/infra-tools"
name = "infra-tools"
~ update_time = "2025-02-03T18:52:32.598189Z" -> "2025-02-05T18:58:06.208591Z"
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["kueue"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/kueue"
name = "kueue"
~ update_time = "2025-02-03T16:51:44.727619Z" -> "2025-02-05T15:48:02.561247Z"
# (12 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.
─────────────────────────────────────────────────────────────────────────────
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo will be updated in-place
~ resource "google_artifact_registry_repository" "repo" {
~ cleanup_policy_dry_run = false -> true
id = "projects/k8s-staging-images/locations/us-central1/repositories/infra-tools"
name = "infra-tools"
# (12 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["test-infra"].google_artifact_registry_repository.repo will be updated in-place
~ resource "google_artifact_registry_repository" "repo" {
~ cleanup_policy_dry_run = false -> true
id = "projects/k8s-staging-images/locations/us-central1/repositories/test-infra"
name = "test-infra"
# (12 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
Note: Objects have changed outside of Terraform
|
@@ -483,7 +483,7 @@ resource "google_cloud_run_service" "oci-proxy" { | |||
// - We need to be able to deploy registry fixes ASAP | |||
// - We will eventually auto-deploy staging by overriding the project and digest on the production config to avoid skew | |||
// If you're interested in running this image yourself releases are available at registry.k8s.io/infra-tools/archeio | |||
image = "gcr.io/k8s-staging-infra-tools/archeio@${var.digest}" | |||
image = "us-central1-docker.pkg.dev/k8s-staging-images/infra-tools/archeio@${var.digest}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only change that requires backfill?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
atlantis plan -p infra/gcp/terraform/k8s-infra-oci-proxy/default |
Plan Error
|
atlantis apply |
Ran Apply for dir: module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo: Modifying... [id=projects/k8s-staging-images/locations/us-central1/repositories/infra-tools]
module.artifact_registry["test-infra"].google_artifact_registry_repository.repo: Modifying... [id=projects/k8s-staging-images/locations/us-central1/repositories/test-infra]
module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo: Modifications complete after 0s [id=projects/k8s-staging-images/locations/us-central1/repositories/infra-tools]
module.artifact_registry["test-infra"].google_artifact_registry_repository.repo: Modifications complete after 0s [id=projects/k8s-staging-images/locations/us-central1/repositories/test-infra]
Apply complete! Resources: 0 added, 2 changed, 0 destroyed. |
Successfully deployed to prod /hold cancel |
Locks and plans deleted for the projects and workspaces modified in this pull request:
|
thank you! filed a rerun on https://prow.k8s.io//view/gs/kubernetes-ci-logs/logs/post-registry-push-images/1887251155981963264 |
Fixing @BenTheElder's comment at kubernetes/registry.k8s.io#298 (comment)
I'm going to backfill the new registry before merging the PR.