gcve: Add tags for failure domain testing and add more comments

[chrischdi]

No description provided.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• infra/gcp/terraform/k8s-infra-gcp-gcve/OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

/assign @sbueringer @fabriziopandini

[fabriziopandini]

Q: are you planning to adding setup GCP Essential Contacts for VMware Engine notifications to this PR?

[fabriziopandini]

What about adding a little bit more context, e.g.

Suggested change

	# Creates the projects (resource pool, folder, assign permissions per resource pool and folder)
	# Creates the projects; each project will map to a resources of type `gcve-vsphere-project` in Boskos
	# and, when assigned to a prow container, it will provide access to a subset of vSphere resources:
	# - A vSphere folder, e.g. `/Datacenter/vm/prow/k8s-infra-e2e-gcp-gcve-project-001`
	# - A vSphere resource pool, e.g. `/Datacenter/host/k8s-gcve-cluster/Resources/prow/k8s-infra-e2e-gcp-gcve-project-001`
	# - A range of IP assigned by boskos-userdata.sh

[chrischdi]

atlantis/plan: infra/gcp/terraform/k8s-infra-gcp-gcve

[chrischdi]

atlantis help

[k8s-infra-ci-robot]

atlantis
Terraform Pull Request Automation

Usage:
  atlantis <command> [options] -- [terraform options]

Examples:
  # show atlantis help
  atlantis help

  # run plan in the root directory passing the -target flag to terraform
  atlantis plan -d . -- -target=resource

  # apply all unapplied plans from this pull request
  atlantis apply

  # apply the plan for the root directory and staging workspace
  atlantis apply -d . -w staging

Commands:
  plan     Runs 'terraform plan' for the changes in this pull request.
           To plan a specific project, use the -d, -w and -p flags.
  apply    Runs 'terraform apply' on all unapplied plans from this pull request.
           To only apply a specific plan, use the -d, -w and -p flags.
  unlock   Removes all atlantis locks and discards all plans for this PR.
           To unlock a specific plan you can use the Atlantis UI.
  approve_policies
           Approves all current policy checking failures for the PR.
  version  Print the output of 'terraform version'
  help     View help.

Flags:
  -h, --help   help for atlantis

Use "atlantis [command] --help" for more information about a command.

[chrischdi]

atlantis plan -d infra/gcp/terraform/k8s-infra-gcp-gcve

[k8s-infra-ci-robot]

Error: User @chrischdi does not have permissions to execute 'plan' command.

[upodroid]

atlantis plan

[k8s-infra-ci-robot]

Ran Plan for 3 projects:

1. dir: infra/gcp/terraform/k8s-infra-gcp-gcve workspace: default
2. dir: infra/gcp/terraform/k8s-infra-gcp-gcve/maintenance-jumphost workspace: default
3. dir: infra/gcp/terraform/k8s-infra-gcp-gcve/vsphere workspace: default

---

2. dir: infra/gcp/terraform/k8s-infra-gcp-gcve/maintenance-jumphost workspace: default

Show Output

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

  # google_compute_instance.jumphost will be updated in-place
~ resource "google_compute_instance" "jumphost" {
        id                         = "projects/broadcom-451918/zones/us-central1-f/instances/maintenance-jumphost"
      ~ metadata                   = {
          ~ "user-data" = (sensitive value)
        }
        name                       = "maintenance-jumphost"
        tags                       = []
        # (22 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

• ▶️ To apply this plan, comment:

  atlantis apply -d infra/gcp/terraform/k8s-infra-gcp-gcve/maintenance-jumphost

• 🚮 To delete this plan and lock, click here
• 🔁 To plan this project again, comment:

  atlantis plan -d infra/gcp/terraform/k8s-infra-gcp-gcve/maintenance-jumphost

Plan: 0 to add, 1 to change, 0 to destroy.

---

3. dir: infra/gcp/terraform/k8s-infra-gcp-gcve/vsphere workspace: default

Plan Error

Show Output

running 'sh -c' '/usr/local/bin/terraform1.10.5 plan -input=false -refresh -out "/atlantis/repos/kubernetes/k8s.io/8148/default/infra/gcp/terraform/k8s-infra-gcp-gcve/vsphere/default.tfplan"' in '/atlantis/repos/kubernetes/k8s.io/8148/default/infra/gcp/terraform/k8s-infra-gcp-gcve/vsphere': exit status 1
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 19:
│   19: variable "vsphere_user" {
│ 
│ The root module input variable "vsphere_user" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 23:
│   23: variable "vsphere_password" {
│ 
│ The root module input variable "vsphere_password" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 27:
│   27: variable "vsphere_server" {
│ 
│ The root module input variable "vsphere_server" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 32:
│   32: variable "nsxt_user" {
│ 
│ The root module input variable "nsxt_user" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 36:
│   36: variable "nsxt_password" {
│ 
│ The root module input variable "nsxt_password" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 41:
│   41: variable "nsxt_server" {
│ 
│ The root module input variable "nsxt_server" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵

---

Plan Summary

3 projects, 1 with changes, 1 with no changes, 1 failed

• ⏩ To apply all unapplied plans from this Pull Request, comment:

  atlantis apply

• 🚮 To delete all plans and locks from this Pull Request, comment:

  atlantis unlock