fix argocd-differ#8972
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/M
Contributor
Argo CD Diff PreviewSummary: No changes foundNo changes found Stats: |
hakman
requested changes
Jan 20, 2026
| name: ibm-ppc64le | ||
| server: http://localhost:8080 | ||
| config: | | ||
| { |
| name: ibm-s390x | ||
| server: http://localhost:8080 | ||
| config: | | ||
| { |
upodroid
force-pushed
the
argocd-differ-patch
branch
from
c4b7b86 to
f3fd71f
Compare
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So our argocd-diff-preview hasn't been working correctly for a few reasons:
Generated 0 applications from 9 ApplicationSets for branch: main (branch: main)this happened because we generate applications from appsets that require the clusters to be added, which is why we apply the clusters.yaml and the differ works correctly.