-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Handler Leak #522
base: master
Are you sure you want to change the base?
Fix Handler Leak #522
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @stasos24! |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jefftree, stasos24 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -72,7 +72,7 @@ func (r *Ref) IsValidURI(basepaths ...string) bool { | |||
if err != nil { | |||
return false | |||
} | |||
|
|||
rr.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the leak fix... it looks like IsValidURI is unused in this repo or in kubernetes/kubernetes, and I don't think we actually want code paths that can be triggered to make network requests from here ... I'm wondering if we should delete IsValidURI entirely
Original source code:
kube-openapi/pkg/validation/spec/ref.go
Lines 70 to 77 in 2c72e55
Fixed Handler leaking before return