Add ip-masq-agent addon to the addons folder.

[dnardo]

This also ensures that under gce we add this DaemonSet if the non-masq-cidr
is set to 0/0.

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Add ip-masq-agent addon to the addons folder which is used in GCE if  --non-masquerade-cidr is set to 0/0

[k8s-ci-robot]

Hi @dnardo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mtaufen]

@k8s-bot ok to test

[mtaufen]

I don't know bash in this much detail, how does this if statement evaluate?
(-n "${NON_MASQUERADE_CIDR:-}") == "0.0.0.0/0"? because True != "0.0.0.0/0"...
(-n "${NON_MASQUERADE_CIDR:-}") && ("${NON_MASQUERADE_CIDR:-}" == "0.0.0.0/0")?

[dnardo]

@mtaufen you are right, good catch thanks.

[mtaufen]

sure thing :)

[mtaufen]

Oops, missed this on my first pass: point this link at https://github.com/kubernetes-incubator/ip-masq-agent/blob/v2.0.0/README.md

Might be better to just link to the README at the version tag used in the manifest in addons/, instead of duplicating the README here.

[dnardo]

@mtaufen Added at a link at the top of the DaemonSet yaml file. Removed readme.

[mtaufen]

one nit in the readme and then /lgtm

[mtaufen]

Also either add a release note or type NONE in the release note section.

[dnardo]

@mtaufen updated the release notes section.

[dnardo]

@k8s-bot unit test this

[mtaufen]

I'm not sure you need this label, https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/addon-manager/README.md seems to say that it's deprecated.

[mtaufen]

/lgtm
I had one comment I missed on my first pass, otherwise LGTM.

[mtaufen]

@k8s-bot unit test this

[dnardo]

@mtaufen removed the cluster-service label.

[mtaufen]

/lgtm

[mtaufen]

@k8s-bot unit test this

[thockin]

/approve

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dnardo, mtaufen, thockin

Details

Needs approval from an approver in each of these OWNERS Files:

• cluster/OWNERS [thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 44606, 46038)