Skip to content

Automated cherry pick of #77483: remove VM API call dep in azure disk WaitForAttach#78439

Closed
MSSedusch wants to merge 1 commit intokubernetes:release-1.13from
MSSedusch:automated-cherry-pick-of-#77483-upstream-release-1.13
Closed

Automated cherry pick of #77483: remove VM API call dep in azure disk WaitForAttach#78439
MSSedusch wants to merge 1 commit intokubernetes:release-1.13from
MSSedusch:automated-cherry-pick-of-#77483-upstream-release-1.13

Conversation

@MSSedusch
Copy link

@MSSedusch MSSedusch commented May 28, 2019

Cherry pick of #77483 on release-1.13.

#77483: remove VM API call dep in azure disk WaitForAttach

@andyzhangx @MSSedusch
remove VM API call dep in azure disk WaitForAttach
dc081fd 
add comment

add unit test for WaitForAttach fnc

add unit test for WaitForAttach Func
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 28, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 28, 2019

@MSSedusch: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 28, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 28, 2019

Hi @MSSedusch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 28, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MSSedusch
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rootfs

If they are not already assigned, you can assign the PR to them by writing /assign @rootfs in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 28, 2019
@MSSedusch
Copy link
Author

MSSedusch commented May 28, 2019

/kind bug
/assign @feiskyer
/sig azure

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/azure and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 28, 2019
@andyzhangx
Copy link
Member

andyzhangx commented May 28, 2019 •
edited
Loading

/hold
Hi @MSSedusch why would you want to cherry pick this PR into old release? We plan to only make this PR available from k8s v1.15.0

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2019
@MSSedusch MSSedusch closed this May 28, 2019
@MSSedusch MSSedusch deleted the automated-cherry-pick-of-#77483-upstream-release-1.13 branch May 28, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@feiskyer feiskyer

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MSSedusch @k8s-ci-robot @andyzhangx @feiskyer