Skip to content

clusterloader2: compute SchedulingThroughput from PodScheduled bind time - #4171

Open
amrmahdi wants to merge 1 commit into
kubernetes:masterfrom
amrmahdi:rewrite-scheduling-throughput
Open

clusterloader2: compute SchedulingThroughput from PodScheduled bind time#4171
amrmahdi wants to merge 1 commit into
kubernetes:masterfrom
amrmahdi:rewrite-scheduling-throughput

Conversation

@amrmahdi

@amrmahdi amrmahdi commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Computes SchedulingThroughput from each pod's PodScheduled LastTransitionTime (the scheduler-stamped bind time) instead of polling and diffing pod counts on the client's clock. The bind time is accurate and not subject to client watch-delivery lag, and because it only reads the pod object it also works where the scheduler /metrics isn't reachable.

Output keeps perc50/90/99/max and adds a perSecond series. Unit test included.

Fixes #1027

clusterloader2: SchedulingThroughput now computes per-second throughput from the scheduler-stamped PodScheduled transition time.

@kubernetes-prow kubernetes-prow Bot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mborsz and wojtek-t June 30, 2026 22:22
@kubernetes-prow

kubernetes-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Welcome @amrmahdi!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow

kubernetes-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amrmahdi
Once this PR has been reviewed and has the lgtm label, please assign mborsz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

kubernetes-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hi @amrmahdi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2026
@amrmahdi
clusterloader2: compute SchedulingThroughput from PodScheduled bind time
a4b1090 
Bucket pods by their PodScheduled LastTransitionTime instead of polling and
diffing counts. The bind time is stamped by the scheduler, so the per-second
throughput is accurate and not subject to client watch-delivery lag.

Output keeps perc50/90/99/max and adds the per-second series; it reads only
the pod object, so it also works where the scheduler /metrics isn't reachable.
Pods scheduled before the measurement starts are ignored. The core is now a
pure function with unit-test coverage.
@amrmahdi
amrmahdi force-pushed the rewrite-scheduling-throughput branch from 46eb7c0 to a4b1090 Compare June 30, 2026 22:23
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mborsz mborsz Awaiting requested review from mborsz
@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-implement scheduling-throughput measurement

1 participant

@amrmahdi