Add --use-existing-prometheus for in-cluster PromQL - #4343
nehadubey1338 wants to merge 2 commits into
Conversation
Measurements currently skip Prometheus unless CL2 deploys its own kube-prometheus stack. Allow querying a Service already in monitoring, with optional --prometheus-service and --prometheus-proxy-scheme. Defaults stay prometheus-k8s over http.
|
Welcome @nehadubey1338! |
|
Hi @nehadubey1338. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nehadubey1338 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@nehadubey1338 please follow the steps to get a CLA, so the EasyCLA tests passes. |
a7f2d21 to
f240d27
Compare
|
/easycla |
f240d27 to
0c70315
Compare
0c70315 to
db50286
Compare
|
/ok-to-test |
Measurements currently skip Prometheus unless CL2 deploys its own kube-prometheus stack. Allow querying a Service already in monitoring, with optional --prometheus-service and --prometheus-proxy-scheme. Defaults stay prometheus-k8s over http.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Measurements currently skip Prometheus unless CL2 deploys its own kube-prometheus stack. Allow querying a Service already in monitoring, with optional --prometheus-service and --prometheus-proxy-scheme. Defaults stay prometheus-k8s over http.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: