Skip to content

Add --use-existing-prometheus for in-cluster PromQL - #4343

Open
nehadubey1338 wants to merge 2 commits into
kubernetes:masterfrom
nehadubey1338:cl2-use-existing-prometheus
Open

nehadubey1338 wants to merge 2 commits into
kubernetes:masterfrom
nehadubey1338:cl2-use-existing-prometheus

Conversation

@nehadubey1338

@nehadubey1338 nehadubey1338 commented Sep 1, 2026

Copy link
Copy Markdown

Measurements currently skip Prometheus unless CL2 deploys its own kube-prometheus stack. Allow querying a Service already in monitoring, with optional --prometheus-service and --prometheus-proxy-scheme. Defaults stay prometheus-k8s over http.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Measurements currently skip Prometheus unless CL2 deploys its own kube-prometheus stack. Allow querying a Service already in monitoring, with optional --prometheus-service and --prometheus-proxy-scheme. Defaults stay prometheus-k8s over http.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Measurements currently skip Prometheus unless CL2 deploys its own
kube-prometheus stack. Allow querying a Service already in monitoring,
with optional --prometheus-service and --prometheus-proxy-scheme.
Defaults stay prometheus-k8s over http.
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 1, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: nehadubey1338 / name: Neha Dubey (db50286)
  • ✅ login: nehadubey1338 / name: nehadubey (a81e7ce)

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 1, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mborsz and wojtek-t September 1, 2026 12:20
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @nehadubey1338!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @nehadubey1338. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nehadubey1338
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 1, 2026
@alaypatel07

Copy link
Copy Markdown
Contributor

@nehadubey1338 please follow the steps to get a CLA, so the EasyCLA tests passes.

@nehadubey1338
nehadubey1338 force-pushed the cl2-use-existing-prometheus branch from a7f2d21 to f240d27 Compare September 8, 2026 16:08
@nehadubey1338

Copy link
Copy Markdown
Author

/easycla

@nehadubey1338
nehadubey1338 force-pushed the cl2-use-existing-prometheus branch from f240d27 to 0c70315 Compare September 8, 2026 16:34
@nehadubey1338
nehadubey1338 force-pushed the cl2-use-existing-prometheus branch from 0c70315 to db50286 Compare September 9, 2026 07:31
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 9, 2026
@alaypatel07

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants