request-benchmark: require --content-type in informer mode by p0lyn0mial · Pull Request #4365 · kubernetes/perf-tests

p0lyn0mial · 2026-09-11T08:51:55Z

make the content-type default to "json" instead of "proto" for the informer mode, matching the http mode.

the only job that runs informer mode sets the content type explicitly to proto.

this PR allows me to also test kubernetes/test-infra#37854

p0lyn0mial · 2026-09-11T08:53:02Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-11T08:53:25Z

/assign @serathius

serathius · 2026-09-11T09:04:48Z

 	apiVersion := fs.String("api-version", "v1", "apiVersion of the target resource (e.g. v1, apps/v1).")
 	resource := fs.String("resource", "secrets", "resource name of the target resource (e.g. pods, deployments).")
-	contentType := fs.String("content-type", "proto", "Content type for informer requests. Valid values: [json, proto]")
+	contentType := fs.String("content-type", "json", "Content type for informer requests. Valid values: [json, proto]")


One ask (I know it's nitpicking), I prefer we didn't have a default. I would prefer that for things like content-type the user needs to explicitly specify so you don't need to read code to confirm what is the default.

it make sense. i will adjust the pr.

p0lyn0mial · 2026-09-11T11:16:15Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

/hold

until the CI jobs above pass.

p0lyn0mial · 2026-09-11T14:14:21Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

serathius · 2026-09-11T14:32:01Z

+		// Re-create stopCh so that a second start/gather cycle can Dispose
+		// cleanly. Dispose closes stopCh, so reusing the one from a previous
+		// cycle (or the constructor) would panic with "close of closed channel".
+		e.stopCh = make(chan struct{})


yeah, just testing :) i don't want to merge it.

Ack, recommend testing locally on kind. It's faster but up to you.

p0lyn0mial · 2026-09-13T10:08:22Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-13T15:56:34Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-14T11:16:59Z

testing #4376

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-14T14:07:04Z

testing kubernetes/test-infra#37866

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-14T16:45:09Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-16T18:50:27Z

I need to bump the number of pods based on:

pull-perf-tests-benchmark-list-informer:
    {
      "data": {
        "Perc50": 300,
        "Perc90": 380,
        "Perc99": 398
      },
      "unit": "ms",
      "labels": {
        "Count": "4038",
        "Resource": "pods",
        "Scope": "cluster",
        "SlowCount": "0",
        "Subresource": "",
        "Verb": "LIST"
      }
    },

and

pull-perf-tests-benchmark-list-proto:
   {
      "data": {
        "Perc50": 300,
        "Perc90": 380,
        "Perc99": 398
      },
      "unit": "ms",
      "labels": {
        "Count": "11422",
        "Resource": "pods",
        "Scope": "cluster",
        "SlowCount": "0",
        "Subresource": "",
        "Verb": "LIST"
      }
    },

p0lyn0mial · 2026-09-17T07:56:09Z

testing with kubernetes/test-infra#37875

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-17T10:33:24Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-17T13:19:16Z

testing with kubernetes/test-infra#37880

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-17T19:19:18Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-18T16:14:19Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-18T19:23:44Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-19T10:06:42Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-20T08:45:19Z

/test pull-perf-tests-benchmark-list-informer
/test pull-perf-tests-benchmark-list-proto

p0lyn0mial · 2026-09-21T13:51:30Z

informer mode:

    {
      "data": {
        "Perc50": 4516.129032,
        "Perc90": 4929.032258,
        "Perc99": 5680
      },
      "unit": "ms",
      "labels": {
        "Count": "260",
        "Resource": "pods",
        "Scope": "cluster",
        "SlowCount": "0",
        "Subresource": "",
        "Verb": "LIST"
      }
    },

http mode:

    {
     "data": {
       "Perc50": 4583.02583,
       "Perc90": 5301.123595,
       "Perc99": 5940.224719
     },
     "unit": "ms",
     "labels": {
       "Count": "643",
       "Resource": "pods",
       "Scope": "cluster",
       "SlowCount": "0",
       "Subresource": "",
       "Verb": "LIST"
     }
   },

To understand the difference in the number of requests between the two modes, we would have to download the logs from the client binary and maybe even add some instrumentation.

p0lyn0mial · 2026-09-21T13:56:47Z

/hold cancel

serathius · 2026-09-21T14:41:52Z

/lgtm
/approve

kubernetes-prow · 2026-09-21T14:42:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2026

kubernetes-prow Bot requested review from jprzychodzen and shyamjvs September 11, 2026 08:52

kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2026

kubernetes-prow Bot assigned serathius Sep 11, 2026

serathius reviewed Sep 11, 2026

View reviewed changes

p0lyn0mial force-pushed the informer-default-json-content-type branch from fde7c7b to de56bac Compare September 11, 2026 11:15

kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2026

p0lyn0mial changed the title ~~request-benchmark: default informer content-type to json~~ request-benchmark: require --content-type in informer mode Sep 11, 2026

kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2026

serathius reviewed Sep 11, 2026

View reviewed changes

p0lyn0mial force-pushed the informer-default-json-content-type branch from b58dfe4 to 2e46f0d Compare September 13, 2026 10:08

p0lyn0mial mentioned this pull request Sep 14, 2026

sig-scalability-presubmit: benchmark list pods only in list proto/informer jobs kubernetes/test-infra#37866

Merged

p0lyn0mial force-pushed the informer-default-json-content-type branch from dc3b0cc to de56bac Compare September 14, 2026 16:43

kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2026

p0lyn0mial mentioned this pull request Sep 16, 2026

sig-scalability-presubmit: bump list benchmark to 80k pods kubernetes/test-infra#37875

Merged

kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2026

p0lyn0mial added 2 commits September 18, 2026 18:08

list benchmark: keep data pods unscheduled via schedulerName

05d23dc

request-benchmark: require --content-type in informer mode

472ee79

p0lyn0mial force-pushed the informer-default-json-content-type branch from f89cc6d to 27460f6 Compare September 18, 2026 16:13

p0lyn0mial force-pushed the informer-default-json-content-type branch from 27460f6 to d2de0db Compare September 18, 2026 19:23

kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2026

list benchmark: increase APISERVER_MEMORY_THRESHOLD_MEGABYTES

c2ecb7f

p0lyn0mial force-pushed the informer-default-json-content-type branch from d2de0db to 3f21b07 Compare September 19, 2026 10:06

kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2026

cl2/list: bump pod mem for the informer mode

7a14415

p0lyn0mial force-pushed the informer-default-json-content-type branch from 3f21b07 to 7a14415 Compare September 20, 2026 08:44

kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2026

kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2026

kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026

kubernetes-prow Bot merged commit 2a436df into kubernetes:master Sep 21, 2026
11 checks passed

Conversation

p0lyn0mial commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p0lyn0mial commented Sep 11, 2026

Uh oh!

p0lyn0mial commented Sep 11, 2026

Uh oh!

serathius Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial commented Sep 11, 2026

Uh oh!

p0lyn0mial commented Sep 11, 2026

Uh oh!

serathius Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

serathius Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial commented Sep 13, 2026

Uh oh!

p0lyn0mial commented Sep 13, 2026

Uh oh!

p0lyn0mial commented Sep 14, 2026

Uh oh!

p0lyn0mial commented Sep 14, 2026

Uh oh!

p0lyn0mial commented Sep 14, 2026

Uh oh!

p0lyn0mial commented Sep 16, 2026

Uh oh!

p0lyn0mial commented Sep 17, 2026

Uh oh!

p0lyn0mial commented Sep 17, 2026

Uh oh!

p0lyn0mial commented Sep 17, 2026

Uh oh!

p0lyn0mial commented Sep 17, 2026

Uh oh!

p0lyn0mial commented Sep 18, 2026

Uh oh!

p0lyn0mial commented Sep 18, 2026

Uh oh!

p0lyn0mial commented Sep 19, 2026

Uh oh!

p0lyn0mial commented Sep 20, 2026

Uh oh!

p0lyn0mial commented Sep 21, 2026

Uh oh!

p0lyn0mial commented Sep 21, 2026

Uh oh!

serathius commented Sep 21, 2026

Uh oh!

kubernetes-prow Bot commented Sep 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

p0lyn0mial commented Sep 11, 2026 •

edited

Loading