Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cluster resource name conflicts #10

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

francostellari
Copy link
Contributor

Summary

This PR aims at fixing a naming conflict for cluster-level resources by prepending the wds name to the resources.
This issues presents itself when multiple WDS are used

Related issue(s)

Fixes #
kubestellar/kubestellar#2021

@nirrozenbaum
Copy link
Collaborator

@francostellari not sure I understand what are you trying to solve here.
what’s the difference between two otp pods both using the same service account + role + binding or each has its own sa + role + binding but the copies are identical?
can you explain?

Copy link
Collaborator

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nirrozenbaum nirrozenbaum merged commit 7a69bcd into kubestellar:main Apr 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants